[OE-core] [PATCH 1/2] quilt: Export missing QUILT_PC variable in ptest Makefile

Randy MacLeod randy.macleod at windriver.com
Thu Aug 22 02:59:37 UTC 2019


    quilt: Export missing QUILT_PC variable in ptest Makefile
is over the 50 character suggested short summary limit:
    quilt: Export QUILT_PC variable in ptest Makefile
works. :)

On 8/21/19 4:01 PM, Trevor Gamblin wrote:
> From: Trevor Gamblin <trevor.gamblin at windriver.com>
> 
> The quilt ptest uses a custom Makefile to implement the
> "make check" rule, but the ptest Makefile does not export
> the value QUILT_PC, which is user-settable and normally
s/value/variable/
> defaults to ".pc". This causes failures e.g. import.test
> with "rm -rf patches/ %{QUILT_PC}/", evaluating to
> "rm -rf patches/ /" if the variable is not set by the
> Makefile. 

Add that:

These ptests broke in:
   73d6034f6b quilt: update to 0.66
when the upstream quilt developers enabled users to specify
their own QUILT_PC string.

../Randy


> 
> Signed-off-by: Trevor Gamblin <trevor.gamblin at windriver.com>
> ---
>   meta/recipes-devtools/quilt/quilt/Makefile | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/quilt/quilt/Makefile b/meta/recipes-devtools/quilt/quilt/Makefile
> index 7b3ac8a..1f6cd24 100644
> --- a/meta/recipes-devtools/quilt/quilt/Makefile
> +++ b/meta/recipes-devtools/quilt/quilt/Makefile
> @@ -2,7 +2,8 @@ PATH :=         $(CURDIR)/bin:$(CURDIR)/compat:$(PATH)
>   QUILT_DIR :=    $(CURDIR)/quilt
>   QUILTRC :=      $(CURDIR)/test/test.quiltrc
>   export QUILT_DIR QUILTRC
> -CHECK_ENV := P=patches/; _P=../patches/; export P _P
> +CHECK_ENV := P=patches/; _P=../patches/; export P _P;
> +CHECK_ENV += QUILT_PC=.pc; export QUILT_PC
>   -include test/.depend
>   
>   check-% : test/%.test
> 


-- 
# Randy MacLeod
# Wind River Linux


More information about the Openembedded-core mailing list