[OE-core] [PATCH 1/1] gettext: avoid useless RPATH QA issue

[Richard Purdie]

On Tue, 2019-08-27 at 10:22 +0800, Chen Qi wrote:
> We are getting useless rpath QA error when enabling libunistring
> and msgcat-curses PACKAGECONFIG. Use chrpath to delete the redundant
> RPATH in binaries.
> 
> Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
> ---
>  meta/recipes-core/gettext/gettext_0.19.8.1.bb | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/meta/recipes-core/gettext/gettext_0.19.8.1.bb
> b/meta/recipes-core/gettext/gettext_0.19.8.1.bb
> index 30121ad..4ce47a6 100644
> --- a/meta/recipes-core/gettext/gettext_0.19.8.1.bb
> +++ b/meta/recipes-core/gettext/gettext_0.19.8.1.bb
> @@ -118,6 +118,14 @@ FILES_gettext-runtime-doc =
> "${mandir}/man1/gettext.* \
>  
>  do_install_append() {
>      rm -f ${D}${libdir}/preloadable_libintl.so
> +    # remove useless rpath to avoid QA issue
> +    useless_rpath_list="${D}${libdir}/gettext/urlget
> ${D}${libdir}/gettext/cldr-plurals \
> +                        ${D}${libdir}/gettext/hostname
> ${D}${bindir}/recode-sr-latin"
> +    for f in $useless_rpath_list; do
> +	if [ -e $f ]; then
> +	    chrpath -d $f
> +	fi
> +    done
>  }
>  
>  do_install_append_class-native () {
> @@ -163,6 +171,8 @@ do_install_ptest() {
>          find ${D}${PTEST_PATH}/ -name "*.o" -exec rm {} \;
>          chmod 0755 ${D}${PTEST_PATH}/tests/lang-vala
> ${D}${PTEST_PATH}/tests/plural-1 ${D}${PTEST_PATH}/tests/xgettext-
> tcl-4 \
>                     ${D}${PTEST_PATH}/tests/xgettext-vala-
> 1  ${D}${PTEST_PATH}/tests/xgettext-po-2
> +        # avoid useless rpath
> +        [ -e ${D}${PTEST_PATH}/src/cldr-plurals ] && chrpath -d
> ${D}${PTEST_PATH}/src/cldr-plurals
>      fi
>  }

In general we try and fix the reason they're getting included in the
first place as it means the compiler flags are incorrect. Any idea why
that is happening and if we can fix it?

Cheers,

Richard