[OE-core] [PATCH 02/15] libdnf: upgrade 0.28.1 -> 0.38.1

[Khem Raj]

On Mon, Dec 2, 2019 at 7:25 AM Alexander Kanavin <alex.kanavin at gmail.com> wrote:
>
> It's using -std=c++11. I'm not sure if switching to gnu flavour would have made a difference with gcc 4.8 provided in centos 7 and gcc 4.9 from Debian 8 - is it worth trying? Newer gcc versions don't complain and build this without error while still using -std=c++11.
>
> I'm leaning towards taking out the dnf/libdnf updates until these distros are retired from the supported distro list.

try adding #include <atomic> in libdnf/dnf-context.cpp

>
> Alex
>
> On Mon, 2 Dec 2019 at 16:10, Adrian Bunk <bunk at stusta.de> wrote:
>>
>> On Mon, Dec 02, 2019 at 02:55:06PM +0000, Ross Burton wrote:
>> > FAILED: libdnf/CMakeFiles/libdnf.dir/dnf-context.cpp.o
>> > /home/pokybuild/yocto-worker/buildtools/build/build/tmp/work/x86_64-linux/libdnf-native/0.38.1-r0/git/libdnf/dnf-context.cpp:2618:8:
>> > error: ‘atomic_flag’ in namespace ‘std’ does not name a type
>> >  static std::atomic_flag cfgMainLoaded = ATOMIC_FLAG_INIT;
>> >         ^
>> > /home/pokybuild/yocto-worker/buildtools/build/build/tmp/work/x86_64-linux/libdnf-native/0.38.1-r0/git/libdnf/dnf-context.cpp:
>> > In function ‘libdnf::ConfigMain& libdnf::getGlobalMainConfig()’:
>> > /home/pokybuild/yocto-worker/buildtools/build/build/tmp/work/x86_64-linux/libdnf-native/0.38.1-r0/git/libdnf/dnf-context.cpp:2622:10:
>> > error: ‘cfgMainLoaded’ was not declared in this scope
>> >      if (!cfgMainLoaded.test_and_set()) {
>> >           ^
>> > This was on a Centos 7 worker...
>>
>> The build should also fail on Ubuntu 16.04.
>>
>> Building with -std=gnu++11 should fix it (untested).
>>
>> > Ross
>>
>> cu
>> Adrian
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core