[OE-core] [PATCH] go: Reset unneeded GOARCH variables for native recipe

Richard Purdie richard.purdie at linuxfoundation.org
Wed Dec 4 12:45:27 UTC 2019


On Mon, 2019-12-02 at 10:26 -0800, Khem Raj wrote:
> These variables depend on TUNE_FEATURES variable and that creeps into
> dependencies for native as well as a result, which means go-native
> gets
> recompiled everytime machine/arch is changed.
> 
> Fixes sstate differences found e.g.
> 
> basehash changed from
> 600fb6be571fa4853232a7fed78945ee19b324e54b1b94cff93ef472b6290103 to
> 994de861190a56064d3e186d9c411152127e230bf2f77b17e59b2c5932a41249
> List of dependencies for variable TUNE_FEATURES changed from
> '{'TUNE_FEATURES_tune-core2-32', 'DEFAULTTUNE'}' to
> '{'TUNE_FEATURES_tune-armv7vethf-neon', 'DEFAULTTUNE'}'
> changed items: {'TUNE_FEATURES_tune-core2-32', 'TUNE_FEATURES_tune-
> armv7vethf-neon'}
> 
> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
>  meta/recipes-devtools/go/go-common.inc | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/meta/recipes-devtools/go/go-common.inc b/meta/recipes-
> devtools/go/go-common.inc
> index f18d928c70..8e4dd137a0 100644
> --- a/meta/recipes-devtools/go/go-common.inc
> +++ b/meta/recipes-devtools/go/go-common.inc
> @@ -37,6 +37,30 @@ export GO386 ?= "${TARGET_GO386}"
>  export GOMIPS ?= "${TARGET_GOMIPS}"
>  export GOROOT_FINAL ?= "${libdir}/go"
> 
> +GOARM[export] = "1"
> +GOARM_class-native = ""
> +GOARM_class-native[export] = "0"

Can we at least do:

GOEXPORTVARS = "1"
GOEXPORTVARS_class-native = "0"

GO386[export] = "${GOEXPORTVARS}"

to clean this up a bit please? :)

Cheers,

Richard



More information about the Openembedded-core mailing list