[OE-core] [PATCH] meta/classes/meson.bbclass: Add inherit setuptools3

Anibal Limon anibal.limon at linaro.org
Wed Dec 4 18:35:38 UTC 2019


On Wed, 4 Dec 2019 at 04:20, Alexander Kanavin <alex.kanavin at gmail.com>
wrote:

> I tend to agree with Khem; this change will pull in target python as build
> and runtime dependency to all meson-using recipes, even those that have
> nothing to do with python.
>

Ok, it depends on python3-setuptools-native I will add this inherit on
waffle recipe.

Regards,
Anibal


>
> I'd suggest you fix the broken recipes individually by adding python3 to
> DEPENDS. Yes, the "not a valid python" message is not helpful; suggestions
> how to improve this are welcome.
>
> Alex
>
> On Wed, 4 Dec 2019 at 03:35, Anibal Limon <anibal.limon at linaro.org> wrote:
>
>>
>>
>> On Tue, 3 Dec 2019 at 17:37, Khem Raj <raj.khem at gmail.com> wrote:
>>
>>>
>>>
>>> On Tue, Dec 3, 2019 at 2:06 PM Aníbal Limón <anibal.limon at linaro.org>
>>> wrote:
>>>
>>>> Fixes,
>>>>
>>>> ...
>>>> | Program python3 found: YES
>>>> (/home/anibal.limon/linaro/oe-rpb-master/build-410c/tmp-rpb-glibc/work/aarch64-linaro-linux/waffle/1.6.0-r0/recipe-sysroot-native/usr/bin/python3-native/python3)
>>>> |
>>>> | meson.build:36:0: ERROR: <ExternalProgram 'python3' ->
>>>> ['/home/anibal.limon/linaro/oe-rpb-master/build-410c/tmp-rpb-glibc/work/aarch64-linaro-linux/waffle/1.6.0-r0/recipe-sysroot-native/usr/bin/python3-native/python3']>
>>>> is not a valid python or it is missing setuptools
>>>> |
>>>> | A full log can be found at
>>>> /home/anibal.limon/linaro/oe-rpb-master/build-410c/tmp-rpb-glibc/work/aarch64-linaro-linux/waffle/1.6.0-r0/build/meson-logs/meson-log.txt
>>>> | WARNING: exit code 1 from a shell command.
>>>> ...
>>>>
>>>
>>> I wonder if it’s better to add this inherit to waffle recipe alone I
>>> doubt that all meson using recipes are building python modules
>>>
>>
>> This issue is triggered from waffle [1] but the actual meson code looks
>> for setuptools [2].
>>
>> Anibal
>>
>> [1]
>> https://gitlab.freedesktop.org/mesa/waffle/blob/master/meson.build#L36
>> [2]
>> https://github.com/mesonbuild/meson/blob/master/mesonbuild/modules/python.py#L578
>>
>>
>>>
>>>
>>>> Signed-off-by: Aníbal Limón <anibal.limon at linaro.org>
>>>> ---
>>>>  meta/classes/meson.bbclass | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/classes/meson.bbclass b/meta/classes/meson.bbclass
>>>> index efa6234078..90868963b7 100644
>>>> --- a/meta/classes/meson.bbclass
>>>> +++ b/meta/classes/meson.bbclass
>>>> @@ -1,4 +1,4 @@
>>>> -inherit siteinfo python3native
>>>> +inherit siteinfo python3native setuptools3
>>>>
>>>>  DEPENDS_append = " meson-native ninja-native"
>>>>
>>>> --
>>>> 2.24.0
>>>>
>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20191204/338956b6/attachment-0001.html>


More information about the Openembedded-core mailing list