[OE-core] [PATCH] alsa-lib:upgrade 1.1.9 -> 1.2.1.1

Ross Burton ross.burton at intel.com
Wed Dec 4 21:45:17 UTC 2019


On 04/12/2019 21:18, Tanu Kaskinen wrote:
> I'll have to ask upstream if the strange configure.ac addition could be
> just removed. If it for some reason won't be removed, then an OE
> specific patch is needed. Either configure.ac needs to be modified to
> operate on ${host_alias}-libtool, or I can simply remove the libtool
> modification part, because OE hasn't needed that in the past, and I
> can't see how it would be needed now.

My understanding is that the used libtool is dropped into the build tree 
by libtoolize, and we've patched libtool to prefix the binary.  So if 
the chunk at the end of configure.ac is kept, then the patch needs to 
alter the correct file.

However that chunk in the configure.ac definitely looks like something 
the author added locally as a test, and forgot to remove when 
committing...  An important line from that wiki page:

"""
Since libtool 1.5.2 (released 2004-01-25), on Linux libtool no longer 
sets RPATH for any directories in the dynamic linker search path, so 
this should no longer be an issue unless upstream used a really old 
version of libtool when creating their distribution tarball.
"""

So I'm not sure why this chunk was added at all.

Ross


More information about the Openembedded-core mailing list