[OE-core] [PATCH] mesa.inc: allow the user to choose the build type

[Ross Burton]

On 11/12/2019 18:40, Khem Raj wrote:
> On Wed, Dec 11, 2019 at 9:23 AM Trevor Woerner <twoerner at gmail.com> wrote:
>>
>> Upstream mesa can either be built as a debug release (the default) or a
>> production release. This patch allows the user to choose which one they
>> want by setting MESA_BUILD_TYPE to either 'production' or 'debug' as
>> they see fit. Under OpenEmbedded a production build will be performed by
>> default.
>>
>> Signed-off-by: Trevor Woerner <twoerner at gmail.com>
>> ---
>>   meta/recipes-graphics/mesa/mesa.inc | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
>> index 5838207e6b..9ad9f2e370 100644
>> --- a/meta/recipes-graphics/mesa/mesa.inc
>> +++ b/meta/recipes-graphics/mesa/mesa.inc
>> @@ -46,6 +46,19 @@ export WANT_LLVM_RELEASE = "${MESA_LLVM_RELEASE}"
>>
>>   MESA_LLVM_RELEASE ?= "${LLVMVERSION}"
>>
>> +# set the MESA_BUILD_TYPE to either 'release' (default) or 'debug'
>> +# by default the upstream mesa sources build a debug release
>> +# here we assume the user will want a release build by default
>> +MESA_BUILD_TYPE ?= "release"
>> +def check_buildtype(d):
>> +    _buildtype = d.getVar('MESA_BUILD_TYPE')
>> +    if _buildtype not in ['release', 'debug']:
>> +        bb.fatal("unknown build type (%s), please set MESA_BUILD_TYPE to either 'release' or 'debug'" % _buildtype)
>> +    if _buildtype == 'debug':
>> +        return 'debugoptimized'
>> +    return 'plain'
>> +MESON_BUILDTYPE = "${@check_buildtype(d)}"
>> +
> 
> Should this also be controlled with DEBUG_BUILD knob

Not convinced.  From what Trevor said on IRC, a Mesa debug build is more 
than just symbols but full on debug output.

Ross