[OE-core] connman dependency of readline

[Peter Kjellerstedt]

> -----Original Message-----
> From: claus.stovgaard at gmail.com <claus.stovgaard at gmail.com>
> Sent: den 11 december 2019 22:11
> To: Peter Kjellerstedt <peter.kjellerstedt at axis.com>; oe-core
> <openembedded-core at lists.openembedded.org>
> Subject: Re: [OE-core] connman dependency of readline
> 
> > > it is set to always depend on readline in the DEPENDS variable,
> > > even though as far as I know it is only the connmanctl which 
> > > depend on readline. In EXTRA_OECONF the --enable-client is 
> > > hardcoded.
> > >
> > > The client is though not included in the image unless you also 
> > > add connman-client.
> > >
> > > So I am thinking on creating a patch where I create a
> > > PACKAGECONFIG[readline] like bluez5, as I would not need the 
> > > client and will need not to include readline because of GPLv3.
> >
> > If readline is only needed to build the connman client and it is
> > packaged in a separate package, then you are only affected by
> > readline's GPL-3.0 license if you install that package. If you do
> > not install it you are ok even if readline is needed during the
> > build. So there should not be any real need to disable the
> > building of the client.
> 
> Thanks for your reply. Was also mixing DEPENDS up with RDEPENDS 
> inside my head.
> 
> Before your mail I had created a small patch and sent. I was
> considering just to request it being dropped, but on the 
> other hand it makes it possible to use
> 
> INCOMPATIBLE_LICENSE = "GPL-3.0"
> 
> without getting below error.
> 
> ERROR: Nothing PROVIDES 'readline' (but /openembedded/oe-
> core/meta/recipes-connectivity/connman/connman_1.37.bb DEPENDS on 
> or otherwise requires it)
> readline was skipped: it has an incompatible license: GPLv3+
> 
> Though fine with me if the patch is dropped.
> 
> As a side note, is there a way for specifing INCOMPATIBLE_LICENSE 
> on an image level, and not as here on the build level? If this is 
> the case, there is no need for my change at all.

Yes. About two months ago, Alexander Kanavin added support for setting 
INCOMPATIBLE_LICENSE per image (see commit fd50395b in OE-Core):

INCOMPATIBLE_LICENSE_pn-core-image-minimal = "GPL-3.0 LGPL-3.0"

> Regards
> Claus

//Peter