[OE-core] [PATCH v2] tune-cortexa72-cortexa53: Add tunes

[Joshua Watt]

On Fri, Dec 13, 2019, 7:21 PM Andre McCurdy <armccurdy at gmail.com> wrote:

> On Fri, Dec 13, 2019 at 4:55 PM Joshua Watt <jpewhacker at gmail.com> wrote:
> >
> > Adds tunes for Cortex-A72 Cortex-A53 big.LITTLE SoCs (with and without
> > crypto extensions), e.g. Rockchip RK3399
> >
> > Signed-off-by: Joshua Watt <JPEWhacker at gmail.com>
> > ---
> >  .../include/tune-cortexa72-cortexa53.inc      | 24 +++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >  create mode 100644
> meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> >
> > diff --git a/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> > new file mode 100644
> > index 00000000000..6bf3b83abe9
> > --- /dev/null
> > +++ b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc
> > @@ -0,0 +1,24 @@
> > +DEFAULTTUNE ?= "cortexa72-cortexa53"
> > +
> > +require conf/machine/include/arm/arch-armv8a.inc
> > +
> > +TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE
> Cortex-A72.Cortex-A53 specific processor optimizations"
> > +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", "
> -march=armv8-a", "" ,d)}"
>

I also think this is redundant because arch-armv8a.inc does it already

> +
> > +TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
> > +
> > +MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES",
> "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
> > +
> > +TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES",
> "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
> > +
> > +# Little Endian base configs
> > +AVAILTUNES += "cortexa72-cortexa53 cortexa72-cortexa53-crypto"
> > +ARMPKGARCH_tune-cortexa72-cortexa53                  =
> "cortexa72-cortexa53"
> > +ARMPKGARCH_tune-cortexa72-cortexa53-crypto           =
> "cortexa72-cortexa53"
> > +TUNE_FEATURES_tune-cortexa72-cortexa53               =
> "${TUNE_FEATURES_tune-armv8a}"
> > +TUNE_FEATURES_tune-cortexa72-cortexa53-crypto        =
> "${TUNE_FEATURES_tune-armv8a-crypto}"
> > +PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53         =
> "${PACKAGE_EXTRA_ARCHS_tune-armv8a} cortexa72-cortexa53"
> > +PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto  =
> "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crypto} cortexa72-cortexa53-crypto"
>
> Shouldn't cortexa72-cortexa53-crypto also be able to use
> cortexa72-cortexa53 packages?
>

Yep. I'll send a v3


> > +BASE_LIB_tune-cortexa72-cortexa53                    = "lib64"
> > +BASE_LIB_tune-cortexa72-cortexa53-crypto             = "lib64"
> > +
> > --
> > 2.23.0
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core at lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20191213/e2154c59/attachment.html>