[OE-core] [PATCH 04/12] qemu: build target variant with gtk+, and nativesdk variant without sdl

[Mark Hatle]

On 2/8/19 9:58 AM, Alexander Kanavin wrote:
> On Fri, 8 Feb 2019 at 16:56, Mark Hatle <mark.hatle at windriver.com> wrote:
>>> Patch 3 changes things in meta-poky/, and patch 4 changes things in
>>> meta/, so they cannot be combined unfortunately. I can however swap
>>> their order, so that there is less confusion.
>>
>> Swap the order and add a copy of the commit message (from 4 to 3) then.  That
>> should lesson anyone's questions if they need to figure out why it changed in
>> the future.
> 
> Currently the commits are:
> 
> commit 341ab87cf326dc1f1d7a3b83d624cde04047f43e
> Author: Alexander Kanavin <alex.kanavin at gmail.com>
> Date:   Thu Dec 27 15:17:26 2018 +0100
> 
>     local.conf.sample: adjust the qemu config to enable gtk+ instead of sdl

Reading the above, I didn't know why you changed the qemu config to enable gtk+.

The commit below has the magic line:

'As sdl is deprecated in favor of gtk+, it should not be the default.'

Once you add that, it's clear to me why the change was made if I ever look at
the local.conf.sample (using git log or git blame).

(Sorry my reply had been delayed, I missed this earlier.)

--Mark

>     Signed-off-by: Alexander Kanavin <alex.kanavin at gmail.com>
> 
> commit 1170d353029dfb3f1a5ed9bab567e353bd034dfa
> Author: Alexander Kanavin <alex.kanavin at gmail.com>
> Date:   Thu Dec 27 15:33:27 2018 +0100
> 
>     qemu: build target variant with gtk+, and nativesdk variant without sdl
> 
>     As sdl is deprecated in favor of gtk+, it should not be the default.
> 
>     Signed-off-by: Alexander Kanavin <alex.kanavin at gmail.com>
> 
> I'm confused, what should go where?
> 
> Alex
>