[OE-core] [PATCH 3/4] libidn2: fix buildpaths qa warning

[Richard Purdie]

On Thu, 2019-02-14 at 21:06 -0500, kai.kang at windriver.com wrote:
> From: Kai Kang <kai.kang at windriver.com>
> 
> Fix buildpaths qa warning of libidn2:
> 
> > WARNING: libidn2-2.0.5-r0 do_package_qa: QA Issue: File
> > /work/core2-64-poky-linux/libidn2/2.0.5-r0/packages-split/libidn2-
> > dev/usr/lib/pkgconfig/libidn2.pc
> > in package contained reference to tmpdir [buildpaths]
> 
> Signed-off-by: Kai Kang <kai.kang at windriver.com>
> ---
>  meta/recipes-extended/libidn/libidn2_2.0.5.bb | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/recipes-extended/libidn/libidn2_2.0.5.bb
> b/meta/recipes-extended/libidn/libidn2_2.0.5.bb
> index 0daf7a6877..da77c4402d 100644
> --- a/meta/recipes-extended/libidn/libidn2_2.0.5.bb
> +++ b/meta/recipes-extended/libidn/libidn2_2.0.5.bb
> @@ -26,4 +26,8 @@ EXTRA_OECONF += "--disable-rpath \
>  LICENSE_${PN} = "(GPLv2+ | LGPLv3)"
>  LICENSE_${PN}-bin = "GPLv3+"
>  
> +do_install_append () {
> +    sed -i 's#${RECIPE_SYSROOT}##'
> ${D}${libdir}/pkgconfig/libidn2.pc
> +}
> +
>  BBCLASSEXTEND = "native nativesdk"

I have a strong dislike for editing .pc files after the fact. Part of
the concern is sed expressions like this bitrot badly, its hard to tell
if they still work as intended.

Is there not a way we can generate a correct .pc file in the first
place even if that means a patch?

Cheers,

Richard