[OE-core] [PATCH 4/7] glib-2.0-native: Break circular dependency on shared-mime-utils
Richard Purdie
richard.purdie at linuxfoundation.org
Sun Feb 17 08:52:44 UTC 2019
On Sat, 2019-02-16 at 22:45 +0000, Peter Kjellerstedt wrote:
> > diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-
> > core/glib-2.0/glib.inc
> > index c9093cee866..7e2847d4b22 100644
> > --- a/meta/recipes-core/glib-2.0/glib.inc
> > +++ b/meta/recipes-core/glib-2.0/glib.inc
> > @@ -80,6 +80,7 @@ FILES_${PN}-utils = "${bindir}/*"
> > RRECOMMENDS_${PN} += "shared-mime-info"
>
> Wouldn't it be clearer to change this to:
>
> RRECOMMENDS_${PN}_append_class-target = " shared-mime-info"
>
> instead of adding the RRECOMMENDS_${PN}_class-native below?
You could argue that both ways, I see the native case as the exception.
Having the mingw32 remove in there is ugly as well and cleaning that up
at the same time might swing it.
Cheers,
Richard
> > # When cross compiling for Windows we don't want to include this
> > RRECOMMENDS_${PN}_remove_mingw32 = "shared-mime-info"
> > +RRECOMMENDS_${PN}_class-native = ""
> >
> > ARM_INSTRUCTION_SET_armv4 = "arm"
> > ARM_INSTRUCTION_SET_armv5 = "arm"
> > --
> > 2.20.1
>
> //Peter
>
>
More information about the Openembedded-core
mailing list