[OE-core] [PATCH v2 1/1] ltp: Update to 20190115

[Khem Raj]

On Sat, Feb 23, 2019 at 8:12 AM Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
>
> On Wed, 2019-01-16 at 16:28 +0100, Petr Vorel wrote:
> > Hi Richard, Khem,
> >
> > > > Thanks for looking at this. Unfortunately it failed in testing on
> > > > most
> > > > targets:
> > > > https://autobuilder.yoctoproject.org/typhoon/#/builders/46/builds/181/steps/7/logs/step1b
> > > > (one failure given as an example).
> > > > Warnings as errors are good during development but sometimes less
> > > > useful during release due to the variety of end user
> > > > configurations.
> > > with glibc 2.29 in play
> > > http://errors.yoctoproject.org/Errors/Details/216829/
> >
> > Thanks for your reports.
> > Is there any way I could easily reproduce it?
> > Some config I can download?
> > I'm testing with default config.
> > I'm sorry for dummy question, I'm more experienced with Buildroot.
>
> Sorry for not replying sooner. We just hit this issue again:
>
> http://errors.yoctoproject.org/Errors/Latest/?filter=480efd388db578106a8a2129c0382b7e56a1ee36&type=commit&limit=150
>
> This time I think I understand where the error is coming from though:
>
> http://git.yoctoproject.org/cgit.cgi/poky/tree/meta/conf/distro/include/security_flags.inc
>
> does:
>
> security_flags.inc:SECURITY_STRINGFORMAT ?= "-Wformat -Wformat-security -Werror=format-security"
> security_flags.inc:SECURITY_CFLAGS ?= "${SECURITY_STACK_PROTECTOR} ${SECURITY_PIE_CFLAGS} ${lcl_maybe_fortify} ${SECURITY_STRINGFORMAT}"
>
> so the reproducer should be to add "-Wformat -Wformat-security
> -Werror=format-security" to CFLAGS when building ltp.
>

I think this must be new, we are carrying patches to fix similar
issues in other parts of ltp. Probably something to consider for
upstreaming
e.g.
https://git.openembedded.org/openembedded-core/tree/meta/recipes-extended/ltp/ltp/0036-testcases-network-nfsv4-acl-acl1.c-Security-fix-on-s.patch

> Cheers,
>
> Richard
>