[OE-core] [PATCH v2 3/5] systemd: create preset files instead of installing in image

[Jonas Bonn]

Hi Peter,


On 07/01/2019 17:43, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: openembedded-core-bounces at lists.openembedded.org <openembedded-
>> core-bounces at lists.openembedded.org> On Behalf Of Jonas Bonn
>>
>> +    def systemd_create_presets(pkg):
>> +        action = get_package_var(d, 'SYSTEMD_AUTO_ENABLE', pkg)
>> +        presetf = oe.path.join(d.getVar("PKGD"), "/lib/systemd/system-preset/98-%s.preset" % pkg)
> 
> Using "/lib" above does not take into account the usrmerge distro
> feature. My suggestion is to use ${nonarch_base_libdir} instead of
> /lib, or maybe even better is to use ${systemd_unitdir} instead of
> /lib/systemd, i.e.:

Yes.  I already had this fixed up locally but using ${systemd_unitdir} 
is smarter than what I've got so I'll do it that way before resubmitting.

Thanks for the review!
/Jonas