[OE-core] [PATCH 2/2] meta: Fix python code quoting issues

Richard Purdie richard.purdie at linuxfoundation.org
Mon Jan 14 23:09:23 UTC 2019


On Mon, 2019-01-14 at 23:06 +0000, Burton, Ross wrote:
> On Mon, 14 Jan 2019 at 23:04, Richard Purdie <
> richard.purdie at linuxfoundation.org> wrote:
> > -    oe_terminal("${SHELL} -c \"make %s; if [ \$? -ne 0 ]; then
> > echo 'Command failed.'; printf 'Press any key to continue... ';
> > read r; fi\"" % d.getVar('KCONFIG_CONFIG_COMMAND'),
> > +    oe_terminal("${SHELL} -c \"make %s; if [ \\$? -ne 0 ]; then
> > echo 'Command failed.'; printf 'Press any key to continue... ';
> > read r; fi\"" % d.getVar('KCONFIG_CONFIG_COMMAND'),
> 
> Would it be neater to use r"" here?

Yes, but it doesn't show what the problem is as clearly. We should
probably clean it up as a follow up.

Cheers,

Richard



More information about the Openembedded-core mailing list