[OE-core] [PATCH 1/1] native.bbclass: remove invalid CONFIG_SITE
Robert Yang
liezhi.yang at windriver.com
Fri Jan 25 02:40:11 UTC 2019
On 1/24/19 8:51 PM, Richard Purdie wrote:
> On Thu, 2019-01-24 at 15:06 +0800, Robert Yang wrote:
>> This CONFIG_SITE has no effect since autotools.bbclass handles it.
>> And the
>> comment line is out of date, it was for "CONFIG_SITE = ''", so remove
>> them.
>
> Going from memory, we had a problem where the path to sed was being
> encoded into scripts (e.g. libtool/autotools and others). It may be
> /usr/bin/sed on some systems and /bin/sed on others.
>
> Are you sure this is no longer a problem?
Yes, that might be a problem, please ignore the patch, and I will update the
comment:
"# Don't use site files for native builds"
To:
# Only use site/native for native builds
// Robert
>
> Cheers,
>
> Richard
>
>> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
>> ---
>> meta/classes/native.bbclass | 3 ---
>> meta/site/native | 1 -
>> 2 files changed, 4 deletions(-)
>> delete mode 100644 meta/site/native
>>
>> diff --git a/meta/classes/native.bbclass
>> b/meta/classes/native.bbclass
>> index ddccfe2..c20c6dc 100644
>> --- a/meta/classes/native.bbclass
>> +++ b/meta/classes/native.bbclass
>> @@ -54,9 +54,6 @@ TOOLCHAIN_OPTIONS = ""
>> # Don't build ptest natively
>> PTEST_ENABLED = "0"
>>
>> -# Don't use site files for native builds
>> -export CONFIG_SITE = "${COREBASE}/meta/site/native"
>> -
>> # set the compiler as well. It could have been set to something else
>> export CC = "${BUILD_CC}"
>> export CXX = "${BUILD_CXX}"
>> diff --git a/meta/site/native b/meta/site/native
>> deleted file mode 100644
>> index 7dfb1cb..0000000
>> --- a/meta/site/native
>> +++ /dev/null
>> @@ -1 +0,0 @@
>> -ac_cv_path_SED=sed
>> --
>> 2.7.4
>>
>
>
More information about the Openembedded-core
mailing list