[OE-core] [PATCH] classes/package: Sort ELF file list
Joshua Watt
jpewhacker at gmail.com
Mon Jun 3 15:29:47 UTC 2019
Sorts the list of detected ELF files by path before processing. This
ensures that when multiple files are hardlinked together the first one
found is always the same. This is required to have reproducible builds.
Signed-off-by: Joshua Watt <JPEWhacker at gmail.com>
---
meta/classes/package.bbclass | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index 4c0a8595363..06948555042 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -1005,6 +1005,12 @@ python split_and_strip_files () {
symlinks[file] = target
results = oe.utils.multiprocess_launch(oe.package.is_elf, checkelf.keys(), d)
+
+ # Sort results by file path. This ensures that the files are always
+ # processed in the same order, which is important to make sure builds
+ # are reproducible when dealing with hardlinks
+ results.sort(key=lambda x: x[0])
+
for (file, elf_file) in results:
# It's a file (or hardlink), not a link
# ...but is it ELF, and is it already stripped?
--
2.21.0
More information about the Openembedded-core
mailing list