[OE-core] [PATCH] Remove manual RDEPENDS from PN-ptest to PN package

richard.purdie at linuxfoundation.org richard.purdie at linuxfoundation.org
Thu Jun 6 22:47:58 UTC 2019


On Thu, 2019-06-06 at 21:44 +0300, Adrian Bunk wrote:
> On Wed, Jun 05, 2019 at 08:10:31PM +0100, Richard Purdie wrote:
> > On Wed, 2019-06-05 at 21:41 +0300, Adrian Bunk wrote:
> > ...
> > > --- a/meta/recipes-devtools/elfutils/elfutils_0.176.bb
> > > +++ b/meta/recipes-devtools/elfutils/elfutils_0.176.bb
> > > @@ -44,7 +44,7 @@ inherit autotools gettext ptest
> > >  
> > >  EXTRA_OECONF = "--program-prefix=eu- --without-lzma"
> > >  EXTRA_OECONF_append_class-native = " --without-bzlib"
> > > -RDEPENDS_${PN}-ptest = "libasm libelf bash make coreutils ${PN}-
> > > binutils ${PN}"
> > > +RDEPENDS_${PN}-ptest = "libasm libelf bash make coreutils ${PN}-
> > > binutils"
> > 
> > Won't that need a += there to preserve the class definition?
> 
> Nice catch, v2 sent.
> 
> > How was this tested?
> 
> It looked obviously correct (famous last words...),
> and I trust that this is breakage that would be
> caught on the autobuilder.

It would get caught by some of my local tests I'm using to check the
ptest dependencies but because the autobuilder uses one image with all
the ptests in, I doubt it would catch it unfortunately :(

Cheers,

Richard



More information about the Openembedded-core mailing list