[OE-core] [meta-oe][PATCH v3 3/4] runqemu: support non-bootable wic images

[Richard Purdie]

On Sat, 2019-06-08 at 09:59 +0200, Adrian Freihofer wrote:
> wic images are handled as vmtype images. Starting qemu with "-kernel"
> parameter and an image of type wic is not supported. Especially for
> "-machine virt" the combination of wic with -kernel parameter would
> be beneficial.
> 
> This patch changes the runqemu script to support this. If QB_MACHINE
> contains "-machine virt" and the image is of type wic a -kernel
> parameter is expected. Otherwise wic images are handled as before.
> 
> Example:
> QB_DEFAULT_FSTYPE = "wic"
> QB_KERNEL_ROOT = "/dev/vda1"
> QB_SYSTEM_NAME = "qemu-system-aarch64"
> QB_MACHINE = "-machine virt"
> ...
> 
> [YOCTO #13336]
> 
> Signed-off-by: Adrian Freihofer <adrian.freihofer at siemens.com>

I'm afraid I don't like this at all, it feels like a horrible interface
which won't scale. The fact the machine sets QB_MACHINE to use virt has
no real relation to whether the image contains a kernel or not, it just
happens to match the current defaults.

Can we add a specific parameter which controls this explicitly?

Perhaps something like a generic "fsinfo" parameter:

QB_FSINFO = "wic:kernel-in-fs"

with wic specific information in it?

I do much prefer the wic-fs and wic-vm change though as it means more
than "wic-nb" did.

Cheers,

Richard