[OE-core] [OE-Core][PATCH] kernel-fitimage: uboot-sign: Check UBOOT_DTB_BINARY before adding deps
richard.purdie at linuxfoundation.org
richard.purdie at linuxfoundation.org
Wed Jun 12 22:21:59 UTC 2019
On Wed, 2019-06-12 at 14:17 -0700, Michael Scott wrote:
> Actually, you can ignore this patch. We debugged the actual race
> condition contributing to the confusion, and that developer will
> submit a new patch with that fix. We can review if that patch makes
> more sense (even without tests).
Well, this patch merged earlier this evening as tested passed. Is that
a problem?
> The test would need to follow:
>
> 1) Is there a pub key in the u-boot.dtb (symlinked file) in the
> deploy
> directory and is it the same as what is generated by mkimage when
> pointing at the fitImage in the deploy directory.
> 2) The race condition affects the build when there is a cached step
> built incorrectly. The cached build step injects the u-boot.dtb
> prior to it being signed.
That does help explain the problem you were seeing and does some like
something we could/should be testing for.
Cheers,
Richard
More information about the Openembedded-core
mailing list