[OE-core] [PATCH 1/1] devtool: warn user about multiple layer having the same base name
Paul Eggleton
paul.eggleton at linux.intel.com
Thu Jun 27 23:25:40 UTC 2019
On Thursday, 27 June 2019 3:14:55 PM NZST Chen Qi wrote:
> Currently `devtool finish RECIPE meta' will silently succeed even
> if there are multiple layers having the same base name of 'meta'.
> e.g. meta layer from oe-core and meta layer from meta-secure-core.
Good catch!
> We should at least give user a warning in such case. With the patch,
> we will get warning like below.
>
> WARNING: Multiple layers have the same base name 'meta', use the first one '<PROJ_DIR>/oe-core/meta'.
> WARNING: Consider using path instead of base name to specify layer:
> <PROJ_DIR>/oe-core/meta
> <PROJ_DIR>/meta-secure-core/meta
>
"use the first one" -> "using the first one"
However I'm wondering if this is the right behaviour. What if the user realises they actually wanted the second one? Given it's a warning the finish operation would have proceeded and the user will have to clean things up manually. Rather than a warning, should we in fact be erroring out and requiring the user to be more specific in this case?
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
More information about the Openembedded-core
mailing list