[OE-core] [thud][PATCH] systemd: RDEPENDS on util-linux-umount
Richard Purdie
richard.purdie at linuxfoundation.org
Thu Mar 7 21:48:02 UTC 2019
On Thu, 2019-03-07 at 15:38 +0000, André Draszik wrote:
> On Thu, 2019-03-07 at 17:18 +0200, Adrian Bunk wrote:
> > On Thu, Mar 07, 2019 at 03:56:33PM +0100, Leon Woestenberg wrote:
> > > On Thu, Mar 7, 2019 at 3:27 PM Adrian Bunk <bunk at stusta.de>
> > > wrote:
> > > > From: André Draszik <andre.draszik at jci.com>
> > > >
> > > > It looks like there is an implicit dependency on util-linux'
> > > > umount - as otherwise when using busybox' umount we see a
> > > > long delay on shutdown / reboot.
> > > >
> > > > [YOCTO #13058]
> > > >
> > > That bug number is wrong, seems only slighty related:
> > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=13058
> > >
> > > Following the discussions, I think this had to do with older
> > > versions
> > > of busybox not ignoring the '-c' option that systemd passes to
> > > umount.
> > >
> > > https://github.com/systemd/systemd/issues/7786
> > >
> > > So, systemd has a dependency on *either* util-linux-mount *or* a
> > > minimal version of busybox. Do we support minimal version
> > > dependencies
> > > in Yocto?
> >
> > Then the patch to master didn't make sense,
> > unfixed busybox is not a problem here.
>
> Yeah, I did ask for my patch to be ignored, and there was further
> discussion
> confirming that it isn't needed these days. Unfortunately my patch
> still
> went in.
>
> http://lists.openembedded.org/pipermail/openembedded-core/2019-February/278893.html
>
>
> > If systemd needs util-linux mount/umount in master it should also
> > depend on them in older releases (both master and thud had systemd
> > 239
> > at that point).
> >
> > If it does not, it should not pull in such dependencies
> > unconditionally
> > in master.
>
> Care to post a patch reverting it on master?
Going from memory I think there were some responses saying we should
probably add this patch regardless since we already needed util-linux-
mount. I didn't think it was a huge issue since mount was already there
and it seemed to solve some problems others were having.
I don't have a strong preference either way, we just need a general
consensus about what to do...
Cheers,
Richard
More information about the Openembedded-core
mailing list