[OE-core] [PATCH] cpulimit: introduce support for this package

[Andre McCurdy]

On Fri, Mar 8, 2019 at 3:24 PM BOUBAKER Bassem via Openembedded-core
<openembedded-core at lists.openembedded.org> wrote:
>
>     * Now, cpulimit recipe is put under recipes-support. Binary will be installed by the recipe under /usr/sbin
>
>         # cpulimit -h
>         Usage: cpulimit [OPTIONS...] TARGET
>                 OPTIONS
>                 -l, --limit=N          percentage of cpu allowed from 0 to 100 (required)
>                 -v, --verbose          show control statistics
>                 -z, --lazy             exit if there is no target process, or if it dies
>                 -i, --include-children limit also the children processes
>                 -h, --help             display this help and exit
>                 TARGET must be exactly one of these:
>                 -p, --pid=N            pid of the process (implies -z)
>                 -e, --exe=FILE         name of the executable program file or path name
>                 COMMAND [ARGS]         run this command and limit it (implies -z)
>
>                 Report bugs to <marlonx80 at hotmail.com>.

A few review comments to address before resubmitting to meta-oe.

> Signed-off-by: Bassem Boubaker <bassem.boubaker at actia.fr>
> ---
>  meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
>
> diff --git a/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb b/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
> new file mode 100644
> index 0000000..d0c524e
> --- /dev/null
> +++ b/meta-oe/recipes-support/cpulimit/cpulimit_0.2.bb
> @@ -0,0 +1,22 @@
> +DESCRIPTION = "cpulimit is a tool which limits the CPU usage of a process from bash prespective"

Typo (or two typos?).

> +HOMEPAGE = "http://cpulimit.sourceforge.net/"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=86c1c0d961a437e529db93aa3bb32dc4"
> +
> +PR = "r0"

No need to set PR to its default.

> +SRCREV ?= "f4d2682804931e7aea02a869137344bb5452a3cd"
> +
> +SRC_URI = "git://git@github.com/opsengine/cpulimit.git;protocol=https"
> +
> +SRC_URI[md5sum] = "4f805fe26c8cf28e8251d64d0ace21d4"
> +SRC_URI[sha256sum] = "544516d0d80c685b1df1344a71c900e845270551cf210300fa4d13876e10817a"

No need for SRC_URI hashes when SRC_URI fetches from git.

> +inherit autotools
> +
> +S = "${WORKDIR}/git"

By convention S should be set before "inherit autotools". Try to stick
to the OE Styleguide unless there's a clear reason to deviate.

  http://www.openembedded.org/wiki/Styleguide

> +do_install() {
> +        install -d ${D}${sbindir}
> +        install -m 0755 ${S}/src/${PN} ${D}${sbindir}/

Even though ${S} and ${B} may be the same directory, conceptually it
makes more sense to install binaries from ${B} (ie the build
directory), rather than ${S} (ie the source directory).

> +}
> \ No newline at end of file

Should be fixed.

> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core