[OE-core] [PATCH 4/5] linux-yocto: Fix systemtap issue on armv7

Bruce Ashfield bruce.ashfield at gmail.com
Mon Mar 11 12:40:38 UTC 2019


On Mon, Mar 11, 2019 at 8:13 AM <richard.purdie at linuxfoundation.org> wrote:
>
> On Sun, 2019-03-10 at 21:27 -0700, Khem Raj wrote:
> > On Sun, Mar 10, 2019 at 8:13 PM Richard Purdie
> > <richard.purdie at linuxfoundation.org> wrote:
> > > Testing stap on armv7 machines was failing due to intermixing of
> > > thumb/arm
> > > instructions. Patch the kernel to always use the v7 march options
> > > since
> > > we know our gcc versions support it to avoid the failure and allow
> > > systemtap to work.
> > >
> > > [YOCTO #13153]
> > >
> >
> > please use the fix that Victor submitted upstream, that way we dont
> > need workaround.
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2019-March/637809.html
>
> I have a feeling that patch may get some discussion upstream. I was
> going to say that the version we're working with is simpler and easier
> to work with until upstream decide what the right approach is. Victor
> as already pointed out that even then I messed it up slightly!
>
> I certainly appreciate getting something upstream and that is the right
> thing to do, I think a simpler workaround for us is fine until that
> gets sorted out though.
>
> I'm particularly conscious that we've not built M3 yet and that Bruce
> has limited availability due to travel so we have a few constraints
> here.

I'm of the same mind. Until the upstream patch is actually queued,
we can easily just stick with the current patch.  That way I can log
the permanent upstream git hash in a revert and update ..  which
is no different than I'd do if I merged the posted patch and then it
eventually merges (or if it needs changes, etc).

So as long as what we merged doesn't break anything, there's no
need to change anything (it isn't a mystery that there's an
upstream fix, even I noticed it last night when scanning my upstream
lists and I'm on vacation :D.

Cheers,

Bruce

>
> Cheers,
>
> Richard
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


More information about the Openembedded-core mailing list