[OE-core] [PATCH] cmake: Reduce verbosity for make invocation

Khem Raj raj.khem at gmail.com
Mon Mar 11 17:18:36 UTC 2019


On Sun, Mar 10, 2019 at 10:53 PM Douglas Royds
<douglas.royds at taitradio.com> wrote:
>
> Since the dawn of time, we have set CMAKE_VERBOSE_MAKEFILE=1 in cmake.bbclass.
> Back in 2016, we also explicitly set VERBOSE=1 in cmake_do_compile(),
> to ensure that make (and ninja) output were verbose in log.do_compile.
>
> Turning off CMAKE_VERBOSE_MAKEFILE=1 means that make (or ninja)
> invocations from the command-line are non-verbose,
> giving CMake's default human-readable output on the terminal instead.
> The user can still invoke VERBOSE=1 make if they do want verbose output.
> This has no effect on the verbose output that goes into the logs.
>

I think it would be better to have knob to turn is on and off both on
console and log files.

> Signed-off-by: Douglas Royds <douglas.royds at taitradio.com>
> ---
>  meta/classes/cmake.bbclass | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
> index fa7f68c99b..e16630434e 100644
> --- a/meta/classes/cmake.bbclass
> +++ b/meta/classes/cmake.bbclass
> @@ -164,7 +164,6 @@ cmake_do_configure() {
>           -DCMAKE_INSTALL_DATAROOTDIR:PATH=${@os.path.relpath(d.getVar('datadir'), d.getVar('prefix'))} \
>           -DCMAKE_INSTALL_SO_NO_EXE=0 \
>           -DCMAKE_TOOLCHAIN_FILE=${WORKDIR}/toolchain.cmake \
> -         -DCMAKE_VERBOSE_MAKEFILE=1 \
>           -DCMAKE_NO_SYSTEM_FROM_IMPORTED=1 \
>           ${EXTRA_OECMAKE} \
>           -Wno-dev
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


More information about the Openembedded-core mailing list