[OE-core] [PATCH] cmake: Reduce verbosity for make invocation

[Douglas Royds]

On 12/03/19 5:09 PM, Khem Raj wrote:

> On Mon, Mar 11, 2019 at 5:47 PM Douglas Royds
> <douglas.royds at taitradio.com> wrote:
>> On 12/03/19 6:18 AM, Khem Raj wrote:
>>
>> On Sun, Mar 10, 2019 at 10:53 PM Douglas Royds
>> <douglas.royds at taitradio.com> wrote:
>>
>> Since the dawn of time, we have set CMAKE_VERBOSE_MAKEFILE=1 in cmake.bbclass.
>> Back in 2016, we also explicitly set VERBOSE=1 in cmake_do_compile(),
>> to ensure that make (and ninja) output were verbose in log.do_compile.
>>
>> Turning off CMAKE_VERBOSE_MAKEFILE=1 means that make (or ninja)
>> invocations from the command-line are non-verbose,
>> giving CMake's default human-readable output on the terminal instead.
>> The user can still invoke VERBOSE=1 make if they do want verbose output.
>> This has no effect on the verbose output that goes into the logs.
>>
>> I think it would be better to have knob to turn is on and off both on
>> console and log files.
>>
>>
>> If you want it on for some reason, you can turn it on in your local.conf:
>>
>> EXTRA_OECMAKE_append=" -DCMAKE_VERBOSE_MAKEFILE=1"
>>
>> Alternatively, you can turn verbosity on for a single invocation (this is what I do when I need it):
>>
>> make VERBOSE=1
>>
>> You can also set an environment variable to make it always verbose, if you want that for some reason:
>>
>> VERBOSE=1 make
>>
>> Do we really need a new variable for this?
> its fine if we can ensure consistent behaviour, I dont like the fact that
> cmdline output would be different than whats stored in log files.


OK, that's a fair point. I'll update it with a variable.