[OE-core] [PATCH] class/sanity: fix broken function check_not_nfs()

[lei yang]

On 2019年03月13日 11:46, Steven Hung (洪于玉) wrote:
> A previous commit 2f44b9b replace oe.utils.getstatusoutput() to subprocess.check_output(). check_output() don't remove a trailling newline. Fix check_not_nfs() by comparing "6969\n".
>
> Signed-off-by: Steven Hung (洪于玉) <Steven.Hung at mediatek.com>
> ---
>   meta/classes/sanity.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index 374dacf4d0..2d96e1e161 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -346,7 +346,7 @@ def get_filesystem_id(path):
>   # Check that the path isn't located on nfs.
>   def check_not_nfs(path, name):
>       # The nfs' filesystem id is 6969
> -    if get_filesystem_id(path) == "6969":
> +    if get_filesystem_id(path) == "6969\n":

if get_filesystem_id(path).strip() == "6969":

will be a lot better here when doing string comparison.

Lei



>           return "The %s: %s can't be located on nfs.\n" % (name, path)
>       return ""
>   
> --
> 2.18.0
>
>

-- 

Test Better, Test Faster, Test Smarter
Test Early, Test Automatically, Test Often

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20190313/a42dd21f/attachment.html>