[OE-core] [PATCH] cross-canadian.bbclass: Do not override LIBCOVERRIDE with SDK libc override

[Richard Purdie]

On Thu, 2019-03-14 at 23:29 -0700, Khem Raj wrote:
> cross-canadian tools are supposed to generate code for target and if
> we
> override the libc override then needed overrides do not get applied
> when
> building gcc cross canadian e.g. for baremetal, which causes build
> failures during compile
> 
> e.g. https://github.com/riscv/meta-riscv/issues/117
> 
> Not override libc override helps us fix this issue
> 
> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
>  meta/classes/cross-canadian.bbclass | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/classes/cross-canadian.bbclass
> b/meta/classes/cross-canadian.bbclass
> index f5c9f61595..ee53faad79 100644
> --- a/meta/classes/cross-canadian.bbclass
> +++ b/meta/classes/cross-canadian.bbclass
> @@ -9,7 +9,6 @@
>  # or indirectly via dependency.  No need to be in 'world'.
>  EXCLUDE_FROM_WORLD = "1"
>  NATIVESDKLIBC ?= "libc-glibc"
> -LIBCOVERRIDE = ":${NATIVESDKLIBC}"
>  CLASSOVERRIDE = "class-cross-canadian"
>  STAGING_BINDIR_TOOLCHAIN =
> "${STAGING_DIR_NATIVE}${bindir_native}/${SDK_ARCH}${SDK_VENDOR}-
> ${SDK_OS}:${STAGING_DIR_NATIVE}${bindir_native}/${TARGET_ARCH}${TARGE
> T_VENDOR}-${TARGET_OS}"

Whilst I understand the problem, we need to be cautious here.

*-cross-canadian-* runs on nativesdk and for example often use glibc
even when the target uses musl. This change is partly reverting fixes
made to ensure that nativesdk worked as glibc (and glibc overrides were
applied correctly) even when the target system used musl.

I think this issue may need more investigation unfortunately...

Cheers,

Richard