[OE-core] [PATCH v2] u-boot: install dumpimage and fit_check_sign in u-boot-tools

[Luca Boccassi]

On Thu, 2019-03-21 at 19:30 +0000, Alex Kiernan wrote:
> On Thu, Mar 21, 2019 at 6:36 PM <luca.boccassi at gmail.com> wrote:
> > From: Luca Boccassi <luca.boccassi at microsoft.com>
> > 
> > Dumpimage and fit_check_sign can be used to extract kernel and
> > ramdisk from
> > a FIT file, verify them and kexec for a faster reboot.
> > 
> > Signed-off-by: Luca Boccassi <luca.boccassi at microsoft.com>
> > Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> > ---
> > v2: add dumpimage and fit_check_sign to FILES_${PN}-mkimage to fix
> > build.
> >     Not sure if it's preferable to do this or to add a new package,
> > please
> >     advise if the other is better.
> > 
> >  meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb | 10 +++++++++-
> >  1 file changed, 9 insertions(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > index ff26e32482..b72033a566 100644
> > --- a/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > +++ b/meta/recipes-bsp/u-boot/u-boot-tools_2019.01.bb
> > @@ -45,11 +45,19 @@ do_install () {
> >         # mkenvimage
> >         install -m 0755 tools/mkenvimage ${D}${bindir}/uboot-
> > mkenvimage
> >         ln -sf uboot-mkenvimage ${D}${bindir}/mkenvimage
> > +
> > +       # dumpimage
> > +       install -m 0755 tools/dumpimage ${D}${bindir}/uboot-
> > dumpimage
> > +       ln -sf uboot-dumpimage ${D}${bindir}/dumpimage
> > +
> > +       # fit_check_sign
> > +       install -m 0755 tools/fit_check_sign ${D}${bindir}/uboot-
> > fit_check_sign
> > +       ln -sf uboot-fit_check_sign ${D}${bindir}/fit_check_sign
> >  }
> > 
> >  ALLOW_EMPTY_${PN} = "1"
> >  FILES_${PN} = ""
> > -FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage"
> > +FILES_${PN}-mkimage = "${bindir}/uboot-mkimage ${bindir}/mkimage
> > {bindir}/uboot-dumpimage ${bindir}/dumpimage
> 
> There's no $ here
> 
> > {bindir}/uboot-fit_check_sign ${bindir}/fit_check_sign"
> 
> or here
> 
> >  FILES_${PN}-mkenvimage = "${bindir}/uboot-mkenvimage
> > ${bindir}/mkenvimage"
> > 
> >  RDEPENDS_${PN}-mkimage += "dtc"

D'oh, copypasta! Thanks, fixed in v3

-- 
Kind regards,
Luca Boccassi