[OE-core] [PATCH] devtool: prevent starting git gc in background

Paul Eggleton paul.eggleton at linux.intel.com
Thu Mar 21 23:25:57 UTC 2019


Hi Taras

On Friday, 22 March 2019 12:08:25 PM NZDT Taras Kondratiuk wrote:
> Devtool creates a git repository for extracted sources in a temporary
> directory and then moves it to a final destination after patching is
> done. Unfortunately devtool is not aware that some of its git operations
> may have caused git garbage collector to start in background. If timing
> is just right a repository move fails because GC is removing git objects
> while they are being moved.
> 
> The issue was hit on Krogoth release, but the code that moves created
> git repository is still the same.
> 
> Disable gc.autodetach to make GC run synchronously and block git until
> it is done.

The fix is OK, but I'd like it to be explicit and say "git config --local"
rather than just "git config" just in case of any future behavioral
changes in git config. Could you please send a v2 with this change?

Thanks,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre




More information about the Openembedded-core mailing list