[OE-core] [PATCH] libcomps: put PV in filename

[Burton, Ross]

On Tue, 26 Mar 2019 at 10:20, Martin Jansa <martin.jansa at gmail.com> wrote:
> http fetcher won't (usually) fetch different version just by changing 1
> variable inside the recipe and vice versa, renaming the recipe won't
> fetch different SRCREV with git.

Sure it will.  gcc_http.bb sets PV=8.3.0 in the recipe, and SRC_URI
uses ${PV}.  The only catch is that http fetches have a secondary
layer of transport checksums that git doesn't have.

> If someone wants to update SRCREV in libcoms to be 10 commits behind
> 0.1.10, is he expected to rename the recipe back to libcomps_git.bb and
> re-add the PV variable (with new +git${SRCPV} suffix)?

Yes.  The recipe ships a release.  If the recipe is changed from
shipping a tested and maintainer approved release to a git snapshot,
that definitely should not be trivial.

> I got used to "+git${SRCPV}" being dropped when the SRCREV matches
> exactly the git tag, but renaming the recipe and removing the PV seems
> too much, what is the benefit of doing that? It's not for clarity or
> easier maintenance (at least for me), because PV next to SRCREV makes
> much more sense to me (and helps people not to forget updating both at
> the same time).

For clarity and consistency: by convention recipes that ship releases
put the PV in the filename.

Ross