[OE-core] [PATCH 1/1] license_image: Don't try to hard link license files

Paul Barker paul at betafive.co.uk
Fri May 3 07:05:17 UTC 2019


On 03/05/2019 06:05, Richard Purdie wrote:
> On Thu, 2019-05-02 at 21:30 +0000, paul at betafive.co.uk wrote:
>> From: Paul Barker <paul at betafive.co.uk>
>>
>> This change allows us to support the placement of WORKDIR and
>> DEPLOY_DIR
>> on different devices. As the license files are typically small, the
>> increase in disk usage and build time should be negligible.
>>
>> Signed-off-by: Paul Barker <paul at betafive.co.uk>
>> ---
>>   meta/classes/license_image.bbclass | 7 ++++---
>>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> We create a lot of hardlinks and its not negligible overall ;-).
> 
> I'd prefer we continue to do so where we can. We should probably create
> a function similar to lib.oe.path.copyhardlinktree() and use that here
> rather than abandon the hardlinks.
> 

Ok, I'll throw together a copyhardlink() helper and send a v2 of this patch.

Thanks,

-- 
Paul Barker
Managing Director & Principal Engineer
Beta Five Ltd


More information about the Openembedded-core mailing list