[OE-core] [PATCH] cml1.bbclass: fix undefined behavior

[Khem Raj]

On Fri, May 3, 2019 at 2:21 AM Stefan Müller-Klieser
<s.mueller-klieser at phytec.de> wrote:
>
> Whenever cml1 do_configure is used with a defconfig, oldconfig waits for
> input. This silently fails with:
> "Error in reading or end of file."
> Replace the call with olddefconfig, which will have the same effect in
> setting all defaults, but has a defined behavior.
>
> Signed-off-by: Stefan Müller-Klieser <s.mueller-klieser at phytec.de>
> ---
>  meta/classes/cml1.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
> index 98d24cec746b..f3b8a84073c8 100644
> --- a/meta/classes/cml1.bbclass
> +++ b/meta/classes/cml1.bbclass
> @@ -1,7 +1,7 @@
>  cml1_do_configure() {
>         set -e
>         unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
> -       oe_runmake oldconfig
> +       oe_runmake olddefconfig

This does not work for busybox/x86_64


| NOTE: make CC=x86_64-yoe-linux-gcc  -m64 -march=core2 -mtune=core2
-msse3 -mfpmath=sse -fstack-protector-strong  -D_FORTIFY_SOURCE=2
--sysroot=/mnt/a/yoe/build/tmp/work/core2-64-yoe-linux/busybox/1.30.1-r0/recipe-sysroot
LD=x86_64-yoe-linux-gcc  -m64 -march=core2 -mtun
e=core2 -msse3 -mfpmath=sse -fstack-protector-strong
-D_FORTIFY_SOURCE=2
--sysroot=/mnt/a/yoe/build/tmp/work/core2-64-yoe-linux/busybox/1.30.1-r0/recipe-sysroot
V=1 ARCH=x86_64 CROSS_COMPILE=x86_64-yoe-linux- SKIP_STRIP=y
HOSTCC=gcc  HOSTCPP=gcc  -E olddefconfig
| make -f scripts/Makefile.build obj=scripts/basic
| /mnt/a/yoe/build/tmp/work/core2-64-yoe-linux/busybox/1.30.1-r0/busybox-1.30.1/scripts/gen_build_files.sh
/mnt/a/yoe/build/tmp/work/core2-64-yoe-linux/busybox/1.30.1-r0/busybox-1.30.1
/mnt/a/yoe/build/tmp/work/core2-64-yoe-linux/busybox/1.30.1-r0/busybox-1.30.1
| mkdir -p include
| make -f scripts/Makefile.build obj=scripts/kconfig olddefconfig
| make[1]: *** No rule to make target 'olddefconfig'.  Stop.
| make: *** [Makefile:445: olddefconfig] Error 2

>  }
>
>  EXPORT_FUNCTIONS do_configure
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core