[OE-core] [PATCH] dhcp: Revert "dhcp: enable gentle shutdown" and reset handler

Richard Purdie richard.purdie at linuxfoundation.org
Tue May 7 09:11:18 UTC 2019


On Tue, 2019-05-07 at 11:06 +0800, Rui Wang wrote:
> This reverts commit 4653fdd4b4cf13543e32fbcf09e50f60c1719a34
> 
> This patch is used to solve the problem in which dhcpd can not
> be killed by SIGINT and SIGTERM. But it seems not good to rely
> on ENABLE_GENTLE_SHUTDOWN, which is an "undesireable feature"
> and will release its address after receive both signal, accoring
> to the comment in "includes/site.h". Then there is no difference
> between "dhclient -x" and "dhclient -r". We can find following
> call trace from source code:
> 
> main() -> dhcp_context_create() -> isc_app_ctxstart()
> -> isc__app_ctxstart()
> 
> The root cause is that exit_action() is registered as the signal
> handler for SIGTERM and SIGINT, which do-nothing as the comment says.
> 
> To fix this problem, we could simply set the default action for
> these two signals if ENABLE_GENTLE_SHUTDOWN is not set.
> 
> Signed-off-by: Rui Wang <rui.wang at windriver.com>

The new patch is missing an Upstream-Status?

Cheers,

Richard



More information about the Openembedded-core mailing list