[OE-core] [PATCH] glib-networking: add PACKAGECONFIG for openssl

[Joshua Watt]

On Fri, May 10, 2019, 8:04 PM Martin Jansa <martin.jansa at gmail.com> wrote:

> On Fri, May 10, 2019 at 04:54:57PM -0700, Khem Raj wrote:
> >
> >
> > On 5/10/19 4:00 PM, Andre McCurdy wrote:
> > > On Fri, May 10, 2019 at 3:16 PM Khem Raj <raj.khem at gmail.com> wrote:
> > >>
> > >> On 5/10/19 3:13 PM, akuster808 wrote:
> > >>> should we change the default to openssl ?
> > >>
> > >> I dont think so. Since newer versions of gnuTLS works okay.
> > >
> > > Isn't one of the goals for OE 2.8 to replace dependencies on [L]GPLv3
> > > components with non-[L]GPLv3 alternatives so that meta-gplv2 can be
> > > deprecated? This would seem to fit that goal exactly.
> >
> > Is that stated somewhere ? while I like the goal probably I missed the
> > memo, my suggestion was just to give openssl backend some time to mature
> > since its relatively new, and maybe give it some soak time
> >
> > >
> > > It wasn't possible to build glib-networking with openssl until very
> > > recently but now that it's supported upstream I think we should
> > > switch.
> > >
> > >    https://github.com/GNOME/glib-networking/blob/master/NEWS
>
> I don't have strong opinion either way.
>
> I didn't want to change the default, because my only motivation was the
> license issue with the newer gnutls, with the PACKAGECONFIG available
> it's easy to change the TLS backend and that's all I need.
>
> Will send v2 if there is some consensus from glib-networking users that
> it should be changed and someone provides me the reasoning for the
> commit message.
>

FWIW, moving away from GPLv3 and/or meta-gplv2 has been discussed in the
2.8 planning meetings:
https://docs.google.com/document/d/1CNEKA4d0eT6-e0hnS2pwi7xdZ5_t6smpZO2HbaJGXbU/edit?usp=drivesdk

Not that it needs to be done right now. It is nice to at least have the
option.


> Cheers,
>
> > >
> > >>> - armin
> > >>>
> > >>> On 5/10/19 2:55 PM, Martin Jansa wrote:
> > >>>> * gnutls from meta-gplv2 isn't new enough for this version of
> glib-networking:
> > >>>>     meson.build:74:0: ERROR:  Invalid version of dependency, need
> 'gnutls' ['>= 3.4.6'] found '3.3.30'
> > >>>>
> > >>>> * disabling gnutls PACKAGECONFIG isn't an option either:
> > >>>>     meson.build:131:2: ERROR:  Problem encountered: No TLS backends
> enabled. Please enable at least one TLS backend
> > >>>>
> > >>>> * add an option to replace gnutls with openssl
> > >>>>
> > >>>> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> > >>>> ---
> > >>>>    meta/recipes-core/glib-networking/glib-networking_2.60.1.bb | 1
> +
> > >>>>    1 file changed, 1 insertion(+)
> > >>>>
> > >>>> diff --git a/meta/recipes-core/glib-networking/
> glib-networking_2.60.1.bb b/meta/recipes-core/glib-networking/
> glib-networking_2.60.1.bb
> > >>>> index 09af229d69..e2b4cffb2b 100644
> > >>>> --- a/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> > >>>> +++ b/meta/recipes-core/glib-networking/glib-networking_2.60.1.bb
> > >>>> @@ -15,6 +15,7 @@ SRC_URI[archive.sha256sum] =
> "d71c6b2faa5ac29100314f08a1be020a2afd0291f025614c0a
> > >>>>    PACKAGECONFIG ??= "gnutls"
> > >>>>
> > >>>>    PACKAGECONFIG[gnutls] =
> "-Dgnutls=enabled,-Dgnutls=disabled,gnutls"
> > >>>> +PACKAGECONFIG[openssl] =
> "-Dopenssl=enabled,-Dopenssl=disabled,openssl"
> > >>>>    PACKAGECONFIG[libproxy] =
> "-Dlibproxy=enabled,-Dlibproxy=disabled,libproxy"
> > >>>>
> > >>>>    EXTRA_OEMESON = "-Dgnome_proxy=disabled"
> > >>>
> > >> --
> > >> _______________________________________________
> > >> Openembedded-core mailing list
> > >> Openembedded-core at lists.openembedded.org
> > >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20190510/cc4e2f9e/attachment.html>