[OE-core] [PATCH 08/10] groff: upgrade 1.22.3 -> 1.22.4

[Hongxu Jia]

On 5/13/19 3:20 AM, Adrian Bunk wrote:
> On Sun, May 12, 2019 at 04:16:28PM +0800, Hongxu Jia wrote:
>> ..
>> --- /dev/null
>> +++ b/meta/recipes-extended/groff/files/0001-support-musl.patch
>> @@ -0,0 +1,46 @@
>> +From f73df5196c35ef9c4531e4b6b26800c41954fd77 Mon Sep 17 00:00:00 2001
>> +From: Hongxu Jia <hongxu.jia at windriver.com>
>> +Date: Sat, 11 May 2019 20:00:29 +0800
>> +Subject: [PATCH] support musl
>> +
>> +...
>> +|./lib/math.h:2877:1: error: 'int signbit(float)' conflicts with a previous declaration
>> +| _GL_MATH_CXX_REAL_FLOATING_DECL_2 (signbit)
>> +| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> +|In file included from recipe-sysroot/usr/include/c++/8.3.0/math.h:36,
>> +|                 from ./lib/math.h:27,
>> +|                 from ./src/include/driver.h:27,
>> +|                 from src/devices/grodvi/dvi.cpp:20:
>> +|recipe-sysroot/usr/include/c++/8.3.0/cmath:661:3: note: previous declaration 'constexpr bool std::signbit(float)'
>> +|   signbit(float __x)
>> +|   ^~~~~~~
>> +...
>> +
>> +Upstream-Status: Pending
>> +
>> +Signed-off-by: Hongxu Jia <hongxu.jia at windriver.com>
>> +---
>> + lib/math.in.h | 2 ++
>> + 1 file changed, 2 insertions(+)
>> ...
> The upstream fix seems to be different, the signbit.m4 part of
> http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=453ff940449bbbde9ec00f0bbf82a359c5598fc7

It's a long story, the git version groff is using submodule gnulib 
rather than itself

http://git.savannah.gnu.org/cgit/groff.git/commit/?id=5fec19d453983bc3127052e4f100110efda93786

Your suggestion works in this situation.

But we do not use git groff, we are building from the source as in 
distributed tarball files which

does not require gnulib any more, so your fix is not suitable for us

SRC_URI = "${GNU_MIRROR}/groff/groff-${PV}.tar.gz \

//Hongxu


> cu
> Adrian
>