[OE-core] [PATCH] autotools.bbclass: output failed config.log

[Hongxu Jia]

On 5/15/19 6:54 PM, Andreas Müller wrote:
> On Wed, May 15, 2019 at 11:50 AM Hongxu Jia <hongxu.jia at windriver.com> wrote:
>> On 5/15/19 5:32 PM, Andreas Müller wrote:
>>
>> --- a/meta/classes/autotools.bbclass
>> +++ b/meta/classes/autotools.bbclass
>> @@ -90,7 +90,11 @@ oe_runconf () {
>>                  bbnote "Running $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} $@"
>>                  if ! ${CACHED_CONFIGUREVARS} $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@"; then
>>                          bbnote "The following config.log files may provide further information."
>> -                       bbnote `find ${B} -ignore_readdir_race -type f -name config.log`
>> +                       config_log="`find ${B} -ignore_readdir_race -type f -name config.log`"
>> +                       bbnote "$config_log"
>> +                       [ -e "$config_log" ] && cat "$config_log" | while read line; do
>> +                               bbnote "$line"
>> +                       done
>>                          bbfatal_log "configure failed"
>>                  fi
>>          else
>> --
>> 2.7.4
>>
>> That output is useful only sometimes and extremly verbose. I'd suggest
>> to introduce a switch to enable/disable (even as newbie user I am able
>> to find config.log). How about making autobuilder's WORKDIR
>> accessible?
>>
>> The output only happens while do_configure failure, it does nothing when build succeed,
>>
>> while failure occurs, I believe related message is the more the better.
>>
>> The autobuilder is just an example, for community development, it is hard to login
>>
>> others build host to debug issue, and we have to take time to reproduce it
>>
>> if we could trace it with a simple glance from the log, why not
>>
> Errors are common at recipe creation. I am asking for a knob to
> prevent me from scrolling through endless wallpapers (confg.logs can
> be >> 100K) to find simple errors.

I think a knob does make sense, I will add it in V2

//Hongxu

> And it just works around an autobuilder hiding useful information,
>
> My 2ct
>
> Andreas