[OE-core] [PATCH 1/2 v3] oeqa/runtime/cases/rpm.py: Enable rpm install dependency testing

[Yeoh, Ee Peng]

Hi Richard,

Yes, you are right, we are checking directory and package on the host server/machine. 
Actually, this message was inherited from within the rpm, I had made the correction on this new patch. I shall submit another patch to correction for the message inside existing rpm test base code. 

Thank you very much for your inputs. 

Thanks,
Yeoh Ee Peng 

-----Original Message-----
From: Richard Purdie [mailto:richard.purdie at linuxfoundation.org] 
Sent: Friday, May 17, 2019 2:02 PM
To: Yeoh, Ee Peng <ee.peng.yeoh at intel.com>; openembedded-core at lists.openembedded.org
Subject: Re: [OE-core] [PATCH 1/2 v3] oeqa/runtime/cases/rpm.py: Enable rpm install dependency testing

Hi Ee Peng,

On Fri, 2019-05-17 at 10:07 +0800, Yeoh Ee Peng wrote:
> Convert manual testcase bsps-hw.bsps-hw.rpm_- 
> __install_dependency_package from oeqa/manual/bsp-hw.json to runtime 
> automated test.
> 
> Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh at intel.com>
> ---
>  meta/lib/oeqa/runtime/cases/rpm.py | 34
> ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/meta/lib/oeqa/runtime/cases/rpm.py
> b/meta/lib/oeqa/runtime/cases/rpm.py
> index d8cabd3..ce3fce1 100644
> --- a/meta/lib/oeqa/runtime/cases/rpm.py
> +++ b/meta/lib/oeqa/runtime/cases/rpm.py
> @@ -135,3 +135,37 @@ class RpmInstallRemoveTest(OERuntimeTestCase):
>          # Check that there's enough of them
>          self.assertGreaterEqual(int(output), 80,
>                                     'Cound not find sufficient amount 
> of rpm entries in /var/log/messages, found {}
> entries'.format(output))
> +
> +    @OETestDepends(['rpm.RpmBasicTest.test_rpm_query'])
> +    def test_rpm_install_dependency(self):
> +        rpmdir = os.path.join(self.tc.td['DEPLOY_DIR'], 'rpm',
> 'noarch')
> +        if not os.path.exists(rpmdir):
> +            self.skipTest('No %s on target' % rpmdir)

This message doesn't sound quite right as you're checking for rpmdir locally on the build server, not on target? Could you clarify that please?

+            if not rpm_tests[rpm]:
+                self.skipTest('No %s on target' % os.path.join(rpmdir, 
+ rpm))

The same issue here, these files are not being searched for "on target".

Cheers,

Richard