[OE-core] [PATCH] virglrenderer: fix compiling failure with `-fvisibility=default'

Alexander Kanavin alex.kanavin at gmail.com
Sun May 19 10:10:16 UTC 2019


On Sun, 19 May 2019 at 07:01, Hongxu Jia <hongxu.jia at windriver.com> wrote:
> +Extern global variable `util_cpu_caps' to multiple C source files is
> +not a good habit, it caused linking failure when making a shard object
> +in some cross compiling circumstance
> +...
> +|ld: gallium/auxiliary/.libs/libgallium.a(u_cpu_detect.o): relocation
> +R_386_GOTOFF against undefined symbol `util_cpu_caps' can not be used
> +when making a shared object
> +|ld: final link failed: bad value
> +...
> +
> +Covert global variable to static and assign it only in one C source file,
> +provide get function for other C source files
> +
> +Upstream-Status: Submitted [virglrenderer-devel at lists.freedesktop.org]

I do not actually see the submission here:
https://lists.freedesktop.org/archives/virglrenderer-devel/2019-May/date.html

I think the patch should be submitted as a merge request here:
https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests

and I would rather wait for upstream to accept it, and then take it in
oe-core as a backport.

Alex


More information about the Openembedded-core mailing list