[OE-core] [PATCH v2] gdb: Upgrade from 8.2.1 to 8.3

[Richard Purdie]

On Fri, 2019-05-17 at 16:53 -0700, Alistair Francis wrote:
> Bump GDB and change the oeqa selftest expression to allow ptests to
> pass.
> 
> Signed-off-by: Alistair Francis <alistair.francis at wdc.com>
> ---
>  meta/conf/distro/include/tcmode-default.inc   |  2 +-
>  meta/lib/oeqa/selftest/cases/package.py       |  2 +-
>  .../gdb/{gdb-8.2.1.inc => gdb-8.3.inc}        | 12 +--
>  .../gdb/gdb-cross-canadian.inc                |  1 -
>  ...ian_8.2.1.bb => gdb-cross-canadian_8.3.bb} |  0
>  .../{gdb-cross_8.2.1.bb => gdb-cross_8.3.bb}  |  0
>  ...1-Fix-build-with-latest-GCC-9.0-tree.patch | 50 ----------
>  ...h => 0001-gdbserver-ctrl-c-handling.patch} |  0
>  ...e-pt_regs-uapi_pt_regs-on-GLIBC-syst.patch | 23 ++---
>  ...-Use-exorted-definitions-of-SIGRTMIN.patch | 16 ++-
>  ...h64-Fix-the-gdb-build-with-musl-libc.patch | 52 ----------
>  .../gdb/gdb/CVE-2017-9778.patch               | 99 ---------------
> ----
>  .../gdb/{gdb_8.2.1.bb => gdb_8.3.bb}          |  0
>  13 files changed, 23 insertions(+), 234 deletions(-)
>  rename meta/recipes-devtools/gdb/{gdb-8.2.1.inc => gdb-8.3.inc}
> (73%)
>  rename meta/recipes-devtools/gdb/{gdb-cross-canadian_8.2.1.bb =>
> gdb-cross-canadian_8.3.bb} (100%)
>  rename meta/recipes-devtools/gdb/{gdb-cross_8.2.1.bb => gdb-
> cross_8.3.bb} (100%)
>  delete mode 100644 meta/recipes-devtools/gdb/gdb/0001-Fix-build-
> with-latest-GCC-9.0-tree.patch
>  rename meta/recipes-devtools/gdb/gdb/{gdbserver-ctrl-c-
> handling.patch => 0001-gdbserver-ctrl-c-handling.patch} (100%)
>  delete mode 100644 meta/recipes-devtools/gdb/gdb/0012-AArch64-Fix-
> the-gdb-build-with-musl-libc.patch
>  delete mode 100644 meta/recipes-devtools/gdb/gdb/CVE-2017-9778.patch
>  rename meta/recipes-devtools/gdb/{gdb_8.2.1.bb => gdb_8.3.bb} (100%)
> 
> diff --git a/meta/conf/distro/include/tcmode-default.inc
> b/meta/conf/distro/include/tcmode-default.inc
> index 668f31324e..744c6c3247 100644
> --- a/meta/conf/distro/include/tcmode-default.inc
> +++ b/meta/conf/distro/include/tcmode-default.inc
> @@ -21,7 +21,7 @@ PREFERRED_PROVIDER_virtual/gettext ??= "gettext"
>  GCCVERSION ?= "8.%"
>  SDKGCCVERSION ?= "${GCCVERSION}"
>  BINUVERSION ?= "2.32%"
> -GDBVERSION ?= "8.2%"
> +GDBVERSION ?= "8.3%"
>  GLIBCVERSION ?= "2.29%"
>  LINUXLIBCVERSION ?= "5.0%"
>  QEMUVERSION ?= "4.0%"
> diff --git a/meta/lib/oeqa/selftest/cases/package.py
> b/meta/lib/oeqa/selftest/cases/package.py
> index 7a00753821..aa13a8df76 100644
> --- a/meta/lib/oeqa/selftest/cases/package.py
> +++ b/meta/lib/oeqa/selftest/cases/package.py
> @@ -134,7 +134,7 @@ class PackageTests(OESelftestTestCase):
>                      return False
>  
>                  # Check debugging symbols works correctly
> -                elif "Breakpoint 1, main () at hello.c:4" in l:
> +                elif re.match("Breakpoint 1.*hello\.c.*4", l):
>                      return True
>  
>              self.logger.error("GDB result:\n%d: %s", status, output)


2019-05-20 19:03:42,463 - oe-selftest - INFO - ======================================================================
2019-05-20 19:03:42,463 - oe-selftest - INFO - ERROR: package.PackageTests.test_gdb_hardlink_debug (subunit.RemotedTestCase)
2019-05-20 19:03:42,464 - oe-selftest - INFO - ----------------------------------------------------------------------
2019-05-20 19:03:42,464 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/lib/oeqa/selftest/cases/package.py", line 148, in test_gdb_hardlink_debug
    if not gdbtest(qemu, binary):
  File "/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/lib/oeqa/selftest/cases/package.py", line 137, in gdbtest
    elif re.match("Breakpoint 1.*hello\.c.*4", l):
NameError: name 're' is not defined

Cheers,

Richard