[OE-core] [PATCH 3/3] elfutils: Fix eu-* utils builds for musl
Khem Raj
raj.khem at gmail.com
Wed May 22 23:29:33 UTC 2019
On Tue, May 21, 2019 at 11:49 PM Adrian Bunk <bunk at stusta.de> wrote:
>
> On Tue, May 21, 2019 at 06:32:28PM -0700, Khem Raj wrote:
> >...
> > PN and PN-binutils is not empty anymore on musl
> >...
> > ++#if !defined(FNM_EXTMATCH)
> > ++# define FNM_EXTMATCH (1 << 5) /* Use ksh-like extended matching. */
> > ++#endif
> >...
>
> This might fix the compilation, but it is horribly wrong.
>
> It passes a flag to a function that this function does not understand.
>
> In the best case the function returns with an error on unknown flags.
>
> In the worst case the function does silently something different from
> what the caller expects it to do.
>
I forgot that the API is provided by libc here so mimic'ing the define
infact could
cause pain. I think its better to nullify it in this case where it is
being used in these
files.
> cu
> Adrian
>
> --
>
> "Is there not promise of rain?" Ling Tan asked suddenly out
> of the darkness. There had been need of rain for many days.
> "Only a promise," Lao Er said.
> Pearl S. Buck - Dragon Seed
>
More information about the Openembedded-core
mailing list