[OE-core] [PATCH V2] alsa-utils: fix multilib names
Tanu Kaskinen
tanuk at iki.fi
Fri May 24 18:59:29 UTC 2019
On Fri, 2019-05-24 at 18:18 +0100, Richard Purdie wrote:
> On Fri, 2019-05-24 at 15:19 +0200, Ming Liu wrote:
> > Wouldn't that break the alsa-utils-scripts? Since ALSA_UTILS_PKGS is
> > being depended by both alsa-utils and alsa-utils-scripts.
> >
> > I did that in V1, but as Richard Purdie pointed out, it will break
> > the alsa-utils-scripts build.
>
> I was about to say we should refactor these recipes and create a common
> inc file.
>
> Looking at the justification in alsa-utils (avoid a bash dependency),
> that is a runtime issue, not a build time one. We should merge these
> recipes and ensure the packaging remains the same.
>
> We can then avoid some of these problems, use PN and have a simpler
> recipe. These changes should be done in multiple commits, one per
> change as usual.
>
> Is there any reason I'm missing not to do this?
I'm not sure if you already found the original commit[1] that
introduced this split. The commit message is:
alsa-utils: Move alsaconf to its own recipe
18575b082a4042376fd1575465e69562dea04ddc added bash as a dependency of
alsa-utils-alsaconf so that the script interpreter will be available at
run time. However, this has the undesirable side effect of making bash
be a build dependency for alsa-utils and, for those folks who don't need
alsaconf but do want some other part of alsa-utils, this cure is worse
than the original disease.
Fix this by moving alsaconf to a separate recipe so that the bash
dependency only applies when alsaconf is specifically requested.
Signed-off-by: Phil Blundell <philb at gnu.org>
Signed-off-by: Saul Wold <sgw at linux.intel.com>
I can't really judge if that justification makes sense. If the
justification is valid, maybe there's a better solution for avoiding
the build dependency on bash for those people who don't need the
scripts?
[1] http://cgit.openembedded.org/openembedded-core/commit/?id=7317c8055cf3af8912a66badb3074f0a60f75ec2
--
Tanu
https://www.patreon.com/tanuk
https://liberapay.com/tanuk
More information about the Openembedded-core
mailing list