[OE-core] [PATCH v3 1/2] local.conf.sample: make systemd as default init manager

[Kang Kai]

On 2019/5/25 上午3:23, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: Khem Raj <raj.khem at gmail.com>
>> Sent: den 23 maj 2019 22:59
>> To: Peter Kjellerstedt <peter.kjellerstedt at axis.com>
>> Cc: kai.kang at windriver.com; openembedded-core at lists.openembedded.org; richard.purdie at linuxfoundation.org
>> Subject: Re: [OE-core] [PATCH v3 1/2] local.conf.sample: make systemd as default init manager
>>
>> On Thu, May 23, 2019 at 1:41 PM Peter Kjellerstedt <mailto:peter.kjellerstedt at axis.com> wrote:
>>> -----Original Message-----
>>> From: mailto:openembedded-core-bounces at lists.openembedded.org <openembedded-
>>> mailto:core-bounces at lists.openembedded.org> On Behalf Of
>>> mailto:kai.kang at windriver.com
>>> Sent: den 23 maj 2019 10:26
>>> To: mailto:richard.purdie at linuxfoundation.org
>>> Cc: mailto:openembedded-core at lists.openembedded.org
>>> Subject: [OE-core] [PATCH v3 1/2] local.conf.sample: make systemd as
>>> default init manager
>>>
>>> From: Kai Kang <mailto:kai.kang at windriver.com>
>>>
>>> Move configurations from local.conf.sample.extended to local.conf.sample
>>> to make systemd as default init manager for poky.
>> If we're going to change the default init manager to be systemd, wouldn't
>> it be more appropriate to change the real default values in bitbake.conf
>> and http://packagegroup-core-boot.bb? And then include an example in
>> local.conf.sample.extended to show how to configure sysvinit as init
>> manager?
>>
>> That would change it for Oe-core and other distributions as well which
>> is not the intention
> Ok, then I'd say the change belongs in poky.conf. Doing this kind of changes
> in local.conf.sample seems very wrong to me. Why? Because if I have an
> existing build tree it will not be affected, but if I setup a new tree with
> oe-init-build-env it will all of a sudden behave differently from the old
> tree. In my mind, local.conf.sample should only be used for things the user
> are likely to want to configure to adapt the build for his/her environment,
> not to define the distribution (that's what poky.conf is for).


If put the settings to poky.conf, it is complicated to override the 
settings and hard for users to turn back to sysvinit when he/she wants.
And every time updates local.conf.sample which is not just update 
comments, the old build and new build are differently, such as

commit 18bead102afabffcf3842ee099dcd22b8a598b8d
Author: Alexander Kanavin <alex.kanavin at gmail.com>
Date:   Wed Feb 27 18:47:33 2019 +0100

     local.conf.sample: adjust the qemu configuration to refer to 
qemu-system-native

     (From meta-yocto rev: aa16ed1b2c0f358d244a50a41be19d80935d3cc8)

     Signed-off-by: Alexander Kanavin <alex.kanavin at gmail.com>
     Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

diff --git a/meta-poky/conf/local.conf.sample 
b/meta-poky/conf/local.conf.sample
index 267108d685..9068e567dc 100644
--- a/meta-poky/conf/local.conf.sample
+++ b/meta-poky/conf/local.conf.sample
@@ -241,7 +241,7 @@ BB_DISKMON_DIRS ??= "\
  # seen. The two lines below enable the SDL backend too. By default 
libsdl2-native will
  # be built, if you want to use your host's libSDL instead of the 
minimal libsdl built
  # by libsdl2-native then uncomment the ASSUME_PROVIDED line below.
-PACKAGECONFIG_append_pn-qemu-native = " sdl"
+PACKAGECONFIG_append_pn-qemu-system-native = " sdl"
  PACKAGECONFIG_append_pn-nativesdk-qemu = " sdl"
  #ASSUME_PROVIDED += "libsdl2-native"


and more earlier:

commit 63dcfa8f1394475073f6dbb5f3f6ede284d5a305
Author: Mark Hatle <mark.hatle at windriver.com>
Date:   Mon Aug 15 16:29:34 2016 -0500

     Revert "local.conf.sample: Disable prelink by default"

     This reverts commit 300f858ba07c938427ccd05a3d7220027a03d461.

     Reenable prelink

     (From meta-yocto rev: 91705d8ae9f56d1de4f0fdcd6a9654b75921aa8c)

     Signed-off-by: Mark Hatle <mark.hatle at windriver.com>
     Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>

diff --git a/meta-poky/conf/local.conf.sample 
b/meta-poky/conf/local.conf.sample
index a7b2d8065d..365b6eb20c 100644
--- a/meta-poky/conf/local.conf.sample
+++ b/meta-poky/conf/local.conf.sample
@@ -152,8 +152,7 @@ EXTRA_IMAGE_FEATURES ?= "debug-tweaks"
  #   - 'image-swab' to perform host system intrusion detection
  # NOTE: if listing mklibs & prelink both, then make sure mklibs is 
before prelink
  # NOTE: mklibs also needs to be explicitly enabled for a given image, 
see local.conf.extended
-# image-prelink disabled for now due to issues with IFUNC symbol relocation
-USER_CLASSES ?= "buildstats image-mklibs"
+USER_CLASSES ?= "buildstats image-mklibs image-prelink"

  #
  # Runtime testing of images


Regards,
Kai

>
> //Peter
>

-- 
Kai Kang