[OE-core] [PATCH] make-mod-scripts: Add nostamp flag on configure task

[richard.purdie at linuxfoundation.org]

On Tue, 2019-05-28 at 07:25 +0000, Bai, Haiqing wrote:
> On Fri, 2019-05-24 at 13:49 +0800, Haiqing Bai wrote:
> > Error appears while building out of tree kernel module
> > l/kernel:do_compile_kernelmodules"
> >  
> > +do_configure[nostamp] = "1"
> > +
> >  DEPENDS += "bc-native"
> >  
> >  EXTRA_OEMAKE = " HOSTCC="${BUILD_CC} ${BUILD_CFLAGS}
> > ${BUILD_LDFLAGS}" HOSTCPP="${BUILD_CPP}""
> 
> This sounds like a really bad idea and will make anything depending
> on
> it rebuild in every build.
> [hqbai:  Actually package 'make-mod-scripts' is a building tool
> needed only by external modules,  if 'anything'   your mean here is
> these external  modules,  then the answer is 'yes',
> These external modules depend on 'make-mod-scripts.',   what's this
> package do is actually equal to  'make scripts'. 

Having all external kernel modules rebuild at every build is not an
acceptable solution.

> We need to ensure that these clean commands are not cleaning things
> out
> of the shared kernel directory that they don't own.
> [hqbai: Since the shared directory is 'kernel-build-
> artifacts/include/config/xxx', kernel is the owner of folder but not
> these files,   I think it does not make sense for kernel to keeps
> these stuff when do  clean/cleanall ]

Only make-mod-scripts should be removing these files since its the one
that has added them.

We should not be running "make clean" in the kernel build tree in those
cases if its going to remove things it doesn't "own".

Cheers,

Richard