[OE-core] [PATCH 05/10] ncurses: fix incorrect UPSTREAM_CHECK_GITTAGREGEX

[Alexander Kanavin]

On Sun, 12 May 2019 at 10:18, Hongxu Jia <hongxu.jia at windriver.com> wrote:

> The upstream git tag has a `upstream/' prefix, such as:
> >>> import re
> >>> pattern = "upstream/(?P<pver>\d+(\.\d+)+(\+\d+)*)"
> >>> string = "upstream/6.1+20181013"
> >>> result = re.match(pattern, string)
> >>> result['pver']
> '6.1+20181013'
>

Have you checked with devtool that this actually works?

Before this commit:
alexander at alexander-box:~/development/poky$ devtool check-upgrade-status
ncurses
INFO: ncurses                   6.1             6.1+20181013    Hongxu Jia <
hongxu.jia at windriver.com> 7a97a7f937762ba342d5b2fd7cd090885a809835

After the commit:
alexander at alexander-box:~/development/poky$ devtool check-upgrade-status
ncurses
INFO: ncurses                   6.1             UNKNOWN_BROKEN  Hongxu Jia <
hongxu.jia at windriver.com>

The code in bitbake/lib/bb/fetch2/git.py actually splits each tag with '/'
as separator and takes only the last part for some reason, so those
prefixes are never a part of the string that is matched against regex.
I'll send a revert in a moment.

Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20190531/2c6f5fde/attachment.html>