[OE-core] [warrior][PATCH 0/8] Backport relevant changes from Zeus

[Peter Kjellerstedt]

> -----Original Message-----
> From: openembedded-core-bounces at lists.openembedded.org <openembedded-core-
> bounces at lists.openembedded.org> On Behalf Of Peter Kjellerstedt
> Sent: den 3 november 2019 16:18
> To: akuster808 <akuster808 at gmail.com>; openembedded-
> core at lists.openembedded.org
> Subject: Re: [OE-core] [warrior][PATCH 0/8] Backport relevant changes from
> Zeus
> 
> > -----Original Message-----
> > From: akuster808 <akuster808 at gmail.com>
> > Sent: den 27 oktober 2019 09:20
> > To: Peter Kjellerstedt <peter.kjellerstedt at axis.com>; openembedded-
> > core at lists.openembedded.org
> > Subject: Re: [OE-core] [warrior][PATCH 0/8] Backport relevant changes
> > from Zeus
> >
> > Peter,
> >
> >
> > On 10/16/19 9:30 AM, Peter Kjellerstedt wrote:
> > > This patch set contains backports of our changes from Zeus that are
> > > relevant for Warrior.
> > >
> > > //Peter
> > >
> > > The following changes since commit
> > 79a850a10a4b88a6d20d607b322542f947874323:
> > >
> > >   conf/poky: add Fedora 30 and Opensuse Leap 15.1 to supported
> > distributions (2019-10-14 09:49:27 +0100)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://push.yoctoproject.org/poky-contrib pkj/warrior_sync
> >
> > The series is causing build failures.
> >
> > https://errors.yoctoproject.org/Errors/Details/274748/
> >
> > https://errors.yoctoproject.org/Errors/Details/274757/
> >
> > I have not had the time to figure out which ones giving I have been
> > working on a different build failure. So if you could double check
> > them,
> > that would be great.
> >
> > regards,
> > Armin
> 
> The problems are caused by the "meson.bbclass: Remove the MESON_*_ARGS
> variables" change. I have not had time to look into why it breaks yet,
> but I can reproduce it so it should hopefully not be too hard to figure
> it out once I have a little time.
> 
> //Peter

Ok, I have figured it out now. It turns out that the change to 
meson.bbclass uncovered a misuse of the meson.cross file. Over a year 
ago, Ross changed meson_array() to return a string instead of an array 
if only one argument is specified. This was for the benefit of cross 
tools specified in the meson.cross file, however it also affected 
properties. Up until now there has always been more than one argument 
for all properties so this did not change anything. However, my change 
to meson.bbclass to remove some unnecessary arguments caused the 
c_link_args for nativesdk to be left with only one argument. 

Support for specifying a property as a string instead of a list was 
added to meson in version 0.50, which is why there never was a problem 
with Zeus due to the change to meson.bbclass. I have now backported 
the relevant part from meson 0.50 and included it in my patch series.

//Peter

> > > Niclas Svensson (1):
> > >   devtool: finish: Keep patches ordered when updating bbappend
> > >
> > > Peter Kjellerstedt (7):
> > >   meson.bbclass: Remove the MESON_*_ARGS variables
> > >   nativesdk-meson: Remove some unused variables
> > >   devtool: Avoid failure for recipes with S == WORKDIR and no local
> > >     files
> > >   package_rpm.bbclass: Remove a misleading bb.note()
> > >   tzdata: Correct the packaging of /etc/localtime and /etc/timezone
> > >   devtool: finish: Add suppport for the --no-clean option
> > >   lib/oe/lsb: Make sure the distro ID is always lowercased
> > >
> > >  meta/classes/meson.bbclass                      | 15 +++++----------
> > >  meta/classes/package_rpm.bbclass                |  5 ++---
> > >  meta/lib/oe/lsb.py                              |  8 ++++----
> > >  .../meson/nativesdk-meson_0.49.2.bb             |  5 -----
> > >  meta/recipes-extended/timezone/tzdata.bb        |  5 +++--
> > >  scripts/lib/devtool/standard.py                 | 17 +++++++++------
> > --
> > >  6 files changed, 23 insertions(+), 32 deletions(-)