[OE-core] [PATCH 3/3] systemd: Add runtime dependency on new ldconfig package

[Andreas Oberritter]

On Thu, 7 Nov 2019 16:58:57 -0800
Andre McCurdy <armccurdy at gmail.com> wrote:

> On Thu, Nov 7, 2019 at 12:55 PM Andreas Oberritter <obi at opendreambox.org> wrote:
> >
> > Signed-off-by: Andreas Oberritter <obi at opendreambox.org>
> > ---
> >  meta/recipes-core/systemd/systemd_243.bb | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/systemd/systemd_243.bb b/meta/recipes-core/systemd/systemd_243.bb
> > index 6e7f95693b..54fcc6a5d1 100644
> > --- a/meta/recipes-core/systemd/systemd_243.bb
> > +++ b/meta/recipes-core/systemd/systemd_243.bb
> > @@ -139,7 +139,7 @@ PACKAGECONFIG[importd] = "-Dimportd=true,-Dimportd=false"
> >  PACKAGECONFIG[iptc] = "-Dlibiptc=true,-Dlibiptc=false,iptables"
> >  PACKAGECONFIG[journal-upload] = "-Dlibcurl=true,-Dlibcurl=false,curl"
> >  PACKAGECONFIG[kmod] = "-Dkmod=true,-Dkmod=false,kmod"
> > -PACKAGECONFIG[ldconfig] = "-Dldconfig=true,-Dldconfig=false"
> > +PACKAGECONFIG[ldconfig] = "-Dldconfig=true,-Dldconfig=false,,ldconfig"
> 
> Is this necessary? The implication of adding it is that you want to
> support situations where ldconfig is disabled in DISTRO_FEATURES (ie
> the new ldconfig package is not pulled in via a runtime dependency
> from glibc) but then manually added to systemd PACKAGECONFIG (ie
> ignoring DISTRO_FEATURES). That just seems like a misconfiguration and
> not something we should try to support.

If you enable ldconfig in systemd, then you clearly always want to install
ldconfig with systemd. That's what this patch makes sure. You can still build
other images without systemd (i.e. with sysvinit) and without ldconfig. That's
what I do.

Regards,
Andreas