[OE-core] [PATCH] archiver: avoid empty incfile in ar_recipe

Andrei Gherzan andrei at gherzan.ro
Mon Nov 11 17:41:50 UTC 2019


Hi,

On 11/11/2019 12:29, Grygorii Tertychnyi (gtertych) wrote:
> Hi Andrei,
> 
> From: Andrei Gherzan <andrei at gherzan.ro>
> Sent: Monday, November 11, 2019 13:18
> Subject: Re: [OE-core] [PATCH] archiver: avoid empty incfile in ar_recipe
> 
>>> Not sure I understand. Archiver class does not interpret "include" directive.
>>> It just parses text files. The regular expression looks correct:
>>>
>>> These lines:
>>>
>>> 440         elif include_re.match(line):
>>> 441             incfile = include_re.match(line).group(1)
>>>
>>> put "${...}" _string_ into "incfile" variable. So, "incfile" is not None at "this stage.
> 
>> "${...}" it's already expanded to a white-space. So in that case it
>> matches "include  ".
> 
> No. "incfile" is not expanded here, it actually contains "${...}", e.g.
> ${@bb.utils.contains('PACKAGECONFIG', 'scripting', 'perf-perl.inc', '', d)}

Give me a simple way to reproduce this.

-- 
Andrei Gherzan


More information about the Openembedded-core mailing list