[OE-core] [PATCH 09/13] Revert "devtool/standard.py: Not filtering devtool workspace for devtool finish"

[Manjukumar Harthikote Matha]

> -----Original Message-----
> From: openembedded-core-bounces at lists.openembedded.org
> <openembedded-core-bounces at lists.openembedded.org> On Behalf Of Richard
> Purdie
> Sent: Monday, November 18, 2019 8:44 AM
> To: Alexander Kanavin <alex.kanavin at gmail.com>; openembedded-
> core at lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 09/13] Revert "devtool/standard.py: Not filtering
> devtool workspace for devtool finish"
> 
> On Mon, 2019-11-18 at 15:28 +0100, Alexander Kanavin wrote:
> > This reverts commit 41d225f4a37d02e9f79bdbfb79caac8cd3d291ce.
> >
> > Unfortunately this change broke 'devtool upgrade' functionality,
> > causing 'devtool finish' to write out an upgraded recipe that no
> > longer includes the original upstream source in SRC_URI.
> >
> > Signed-off-by: Alexander Kanavin <alex.kanavin at gmail.com>
> > ---
> >  scripts/lib/devtool/standard.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/lib/devtool/standard.py
> > b/scripts/lib/devtool/standard.py index 8d9c1a30225..1c0cd8ab51b
> > 100644
> > --- a/scripts/lib/devtool/standard.py
> > +++ b/scripts/lib/devtool/standard.py
> > @@ -2021,7 +2021,7 @@ def finish(args, config, basepath, workspace):
> >      remove_work=args.remove_work
> >      tinfoil = setup_tinfoil(basepath=basepath, tracking=True)
> >      try:
> > -        rd = parse_recipe(config, tinfoil, args.recipename, True,
> > False)
> > +        rd = parse_recipe(config, tinfoil, args.recipename, True)
> >          if not rd:
> >              return 1
> 
> Are we missing a test case for something here?
> 
> If yes, would that be worth noting in bugzilla whilst we know about it?
> 

We will work on adding some of the test cases as well. The functionality of devtool is broad, it has various features and patches sent are missing testing every single functionality

Thanks,
Manju