[OE-core] [PATCH v3 00/17] NPM refactoring

[Jean-Marie LEMETAYER]

Hi Tim,

On Nov 21, 2019, at 7:36 AM, Tim Orling timothy.t.orling at linux.intel.com wrote:
>> On Nov 20, 2019, at 10:27 PM, Tim Orling <timothy.t.orling at linux.intel.com>
>> wrote:
>>> On Nov 20, 2019, at 1:33 AM, Jean-Marie LEMETAYER
>>> <jean-marie.lemetayer at savoirfairelinux.com
>>> <mailto:jean-marie.lemetayer at savoirfairelinux.com>> wrote:
>>> 
>>> The test steps are these ones:
>>>  $ source poky/oe-init-build-env
>>>  $ bitbake-layers add-layer ../meta-openembedded/meta-oe
>>>  $ devtool add
>>>  "npm://registry.npmjs.org;name=@savoirfairelinux/node-server-example;version=latest
>>>  <npm://registry.npmjs.org%3Bname%3D@savoirfairelinux/node-server-example;version=latest>”
>> 
>> I noticed this before but forgot to report it:
>> 
>> ERROR: Nothing PROVIDES 'c-ares-native' (but
>> virtual:native:/build/meta-openembedded/meta-oe/recipes-devtools/nodejs/nodejs_10.17.0.bb
>> DEPENDS on or otherwise requires it). ...
>> http://layers.openembedded.org/layerindex/recipe/50318/
>> <http://layers.openembedded.org/layerindex/recipe/50318/>
>> $ bitbake-layers add-layer ../meta-openembedded/meta-networking
>> Which requires
>> $ bitbake-layers add-layer ../meta-openembedded/meta-python
>> 
>> 
>> Using tip of bitbake with V3, openembedded-core with V3 and meta-openembedded
>> master, somehow nodejs-native do_compile broke (at least on qemux86-64) since
>> the last time I built it shortly after ELC-E…
>> So now I’ll have to git bisect that…more to come…
> 
> See https://errors.yoctoproject.org/Errors/Details/274939/
> <https://errors.yoctoproject.org/Errors/Details/274939/>
> The same error I am seeing.
> 
>> 
>> FWIW I had previously successfully run your instructions and the tests for both
>> bitbake and oe-selftest for V2 (distroless, e.g. not with poky). Something
>> unrelated has broken I suspect.

Thanks for your feedback.

Since ELCE the nodejs recipe have received some patches including this one:
http://lists.openembedded.org/pipermail/openembedded-devel/2019-October/202636.html

And was updated to 10.17.0:
http://lists.openembedded.org/pipermail/openembedded-devel/2019-October/202639.html

But since it is concerning the nodejs recipe and not the npm fetcher/class
do you think it should block the patchset ?

>>>  $ devtool build savoirfairelinux-node-server-example
>>>  $ bitbake-layers create-layer ../meta-test
>>>  $ bitbake-layers add-layer ../meta-test
>>>  $ devtool finish savoirfairelinux-node-server-example ../meta-test
>>>  $ echo IMAGE_INSTALL_append = '" savoirfairelinux-node-server-example"' >>
>>>  conf/local.conf
>>>  $ bitbake core-image-minimal
>>> 
>>> --- V2
>>> 
>>> - Add a 'recipetool.RecipetoolTests.test_recipetool_create_npm' test case for
>>>   'oe-selftest' to test the npm recipe creation.
>>> 
>>> --- V3
>>> 
>>> - Add a test regarding the 'devtool add' and 'devtool build' command:
>>>     - devtool.DevtoolAddTests.test_devtool_add_npm

I had a lot of requests about tests. What do you think about these ?
FYI some fetcher tests have also been posted in the bitbake mailing list.

Regards,
Jean-Marie